Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Brave is crashing when opening View all version info. while in Landscape mode and then switching to Portrait mode #36098

Closed
soner-yuksel opened this issue Feb 14, 2024 · 2 comments · Fixed by brave/brave-core#22497
Assignees
Labels
crash OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - iPhone QA/Yes release-notes/include

Comments

@soner-yuksel
Copy link

Description:

Follow-up to #8705

Steps to Reproduce

  1. Install and launch Brave 1.62 (24.2.8.16)
  2. Three-dot menu > Settings
  3. Rotate the iPhone to Landscape mode
  4. About > Tap Version... > Tap View all version info.
  5. Rotate the iPhone to Portrait mode > Observe Brave is crashing
  6. Launch Brave again
  7. Repeat Steps 2 - 5 but this time do it in Portrait mode and then rotate the device to Landscape mode
  8. Observe Brave is freezing and View all version info. page is not aligned

Actual result:

Observe 3 issues here when going through the same steps:

  1. Brave is crashing when opening View all version info. while in Landscape mode and then switching to Portrait mode.
  2. Brave is freezing when opening View all version info. while in Portrait mode and then switching to Landscape mode.
  3. View all version info. is not properly aligned when opening while in Portrait mode and then switching to Landscape mode.

Brave crash

F48FE462-69B6-46A5-9B1D-598CBE129F63.MP4

Brave freeze

4530E617-32A8-4DDA-8BD1-B93F725989DD.MP4

Expected result:

Brave must not crash or freeze.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Brave build: 1.62 (24.2.8.16)
BraveCore: 1.62.158 (121.0.6167.139)
  • Can you reproduce this issue with the most recent build from TestFlight? YES
  • Can you reproduce this issue with the previous version of the current build from TestFlight? N/A
  • Can you reproduce this issue with the current build from AppStore? N/A

Device details:

iPhone 14 / iOS 17.4 Beta

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

Reference for iOS Issue: brave/brave-ios#8752

@kjozwiak
Copy link
Member

The above requires 1.64.103 or higher for 1.64.x verification 👍

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 21, 2024
@hffvld
Copy link
Contributor

hffvld commented Mar 21, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.4
Brave build: 1.64 (109)
BraveCore: 1.64.109 (123.0.6312.58)

STEPS:

  1. Follow the steps from [iOS] Brave is crashing when opening View all version info. while in Landscape mode and then switching to Portrait mode #36098 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that Brave is not crashing or freezing

1080.mov

@hffvld hffvld added QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants