Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Follow up to PR #22293][L10n] Send button is overlapping the query/string because it wasn't moved to the left side of the text field for RTL #36413

Closed
hffvld opened this issue Feb 28, 2024 · 2 comments · Fixed by brave/brave-core#22363
Labels
browser-ai bug l10n OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include

Comments

@hffvld
Copy link
Contributor

hffvld commented Feb 28, 2024

Description

Follow-up to #22293

Steps to reproduce

  1. Change device language to any RTL, for example, Arabic or Hebrew
  2. Launch Brave
  3. Three-dot menu > Leo
  4. Observe that the Send button is not mirrored for RTL and overlaps the string/query

Actual result

1 2
1 2

The Send button overlaps the query/string because it wasn't moved to the left side of the text field for RTL.

Expected result

The Send button must be moved to the left side of the text field for RTL, so it will not overlap the string/query.

Issue reproduces how often

Easily reproduced

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NO
  • Can you reproduce this issue with the current Play Store Beta version? NO
  • Can you reproduce this issue with the current Play Store Nightly version? YES

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): PHONE
  • Android version: ANY

Brave version

Brave build: 1.65.40 
Chromium: 122.0.6261.69 (Official Build) canary (64-bit) 

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@kjozwiak
Copy link
Member

kjozwiak commented Mar 4, 2024

The above requires 1.63.168 or higher for 1.63.x verification 👍

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 5, 2024
@hffvld
Copy link
Contributor Author

hffvld commented Mar 5, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 AP21.240119.009 release-keys
Brave build: 1.63.168
Chromium: 122.0.6261.94 (Official Build) (64-bit) 

STEPS:

  1. Follow the steps from [Follow up to PR #22293][L10n] Send button is overlapping the query/string because it wasn't moved to the left side of the text field for RTL #36413 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the Send button is on the left side of the text field for RTL.

1 2 3 4
1 2 3 4

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-ai bug l10n OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants