Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Private History page to use Brave graphics #36530

Closed
srirambv opened this issue Mar 4, 2024 · 2 comments · Fixed by brave/brave-core#22445
Closed

Update Private History page to use Brave graphics #36530

srirambv opened this issue Mar 4, 2024 · 2 comments · Fixed by brave/brave-core#22445
Assignees

Comments

@srirambv
Copy link
Contributor

srirambv commented Mar 4, 2024

Description

Update Private History page to use Brave graphics

Steps to reproduce

  1. Open a private tab
  2. Open Menu
  3. Click on Hisotry, shows Chromium graphics instead of Brave

Actual result

Expected result

Use Brave graphics

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

All

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @aguscruiz @samartnik @kjozwiak @hffvld @Uni-verse

@samartnik
Copy link
Contributor

New updated images:

Screenshot_20240304_101120
Screenshot_20240304_101241

@hffvld
Copy link
Contributor

hffvld commented Mar 28, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 AP21.240216.010 release-keys
Brave build: 1.65.89 
Chromium: 123.0.6312.58 (Official Build) beta (64-bit) 

STEPS:

  1. Follow the steps from Update Private History page to use Brave graphics #36530 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that we use Brave graphic in Private History tab

1 2
1 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants