Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Brave VPN bottom sheet modal is not fully shown while device is in Landscape mode #37431

Closed
hffvld opened this issue Apr 9, 2024 · 4 comments · Fixed by brave/brave-core#23296
Assignees
Labels
bug feature/vpn OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include

Comments

@hffvld
Copy link
Contributor

hffvld commented Apr 9, 2024

Description

The Disable Brave VPN bottom sheet modal is not fully shown while the device is in Landscape mode.

Steps to reproduce

  1. Launch Brave
  2. Enable VPN
  3. While VPN is ON rotate the device (phone or tablet) into Landscape mode
  4. Three-dot menu > Brave VPN
  5. Tap to disable it > Observe

Actual result

The Disable Brave VPN bottom sheet modal is not fully shown while the device is in Landscape mode. In the past, we had a similar issue with Brave News, which has been fixed already.

Tablet Phone
1 2

Expected result

The Disable Brave VPN bottom sheet modal must be fully shown while the device is in Landscape mode.

Tablet Phone
1 2

Issue reproduces how often

Easily reproduced

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? YES
  • Can you reproduce this issue with the current Play Store Beta version? YES
  • Can you reproduce this issue with the current Play Store Nightly version? YES

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone and Tablet
  • Android version: ANY

Brave version

Brave build: 1.66.70
Chromium: 124.0.6367.29 (Official Build) canary (64-bit)

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@hffvld hffvld added bug QA/Yes OS/Android Fixes related to Android browser functionality feature/vpn labels Apr 9, 2024
@hffvld
Copy link
Contributor Author

hffvld commented Apr 9, 2024

The same issue was observed for the Liking Brave? bottom sheet modal.

Device is in Landscape mode: Brave > Three-dot menu > Settings > Scroll down > Rate Brave > Observe


1 2 3
1 2 3

@deeppandya deeppandya self-assigned this Apr 10, 2024
@deeppandya deeppandya added the priority/P2 A bad problem. We might uplift this to the next planned release. label Apr 10, 2024
@deeppandya
Copy link

@hffvld i will be creating a separate issue for #37431 (comment).

@deeppandya
Copy link

@hffvld created the issue #37870 for rate brave

@brave-builds brave-builds added this to the 1.67.x - Nightly milestone Apr 29, 2024
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 21, 2024
@hffvld
Copy link
Contributor Author

hffvld commented May 21, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 AP31.240426.022 release-keys
Brave build: 1.67.85 
Chromium: 125.0.6422.60 (Official Build) beta (64-bit) 

STEPS:

  1. Follow the steps from Disable Brave VPN bottom sheet modal is not fully shown while device is in Landscape mode #37431 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the Disable Brave VPN bottom sheet modal is fully shown while the device is in Landscape mode.
  • Verified the the behavior is correct during device rotation while the Disable Brave VPN bottom sheet modal is already opened

1 2
1 2
timestamp_13-05-40_13-06-02.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/vpn OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants