Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve checkbox area that can be tapped in Wallet onboarding initial screen #37499

Closed
simoarpe opened this issue Apr 11, 2024 · 1 comment · Fixed by brave/brave-core#23026
Closed

Improve checkbox area that can be tapped in Wallet onboarding initial screen #37499

simoarpe opened this issue Apr 11, 2024 · 1 comment · Fixed by brave/brave-core#23026
Assignees
@simoarpe
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.67.x - Release

Comments

@simoarpe
Copy link

simoarpe commented Apr 11, 2024 •
edited
Loading

Description

For some languages, the checkboxes in the initial screen for the Wallet onboarding flow, can be hardly tapped.

Slack discussion: https://bravesoftware.slack.com/archives/C0816QH3R/p1712657579528449

Steps to reproduce

The issue is reproducible only in specific languages.

  1. Navigate to create a new Wallet
  2. In the initial screen, try to select the checkboxes by tapping on them
  3. Observe the tap does not apply the check

Issue reproduces how often

The issue seems to be easily reproducible only in specific languages.
@simoarpe simoarpe added bug priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels Apr 11, 2024
@simoarpe simoarpe self-assigned this Apr 11, 2024
@simoarpe simoarpe mentioned this issue Apr 11, 2024
Merged
24 tasks
@brave-builds brave-builds added the feature/web3/wallet Integrating Ethereum+ wallet support label Apr 11, 2024
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone Apr 11, 2024
@srirambv
Copy link
Contributor

Verification passed on Google Pixel 8 with Android 14 running 1.67.98 x64 Beta build

  • Verified steps from brave/brave-core#23026
  • Verified tap area for buttons is bigger on the wallet onboarding on all screens

@kjozwiak kjozwiak mentioned this issue Jun 14, 2024
Closed
@hffvld hffvld mentioned this issue Jun 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simoarpe simoarpe

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.67.x - Release
Development

Successfully merging a pull request may close this issue.

(Wallet) Improve checkbox padding on terms of use screen brave/brave-core
3 participants
@simoarpe @srirambv @brave-builds