Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Wallet) Improve checkbox padding on terms of use screen #23026

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

simoarpe
Copy link
Collaborator

Resolves brave/brave-browser#37499

Screenshot_1712823988

Improve horizontal padding for checkboxes from 8dp to 16dp.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Test checkboxe tappable area of terms of use screen in multiple languages
  • Observe the checkboxes are easily tappable

@simoarpe simoarpe added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS feature/web3/wallet CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Apr 11, 2024
@simoarpe simoarpe self-assigned this Apr 11, 2024
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@simoarpe simoarpe merged commit 845f290 into master Apr 11, 2024
20 checks passed
@simoarpe simoarpe deleted the simone/improve-checkbox-padding branch April 11, 2024 13:24
@github-actions github-actions bot added this to the 1.67.x - Nightly milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve checkbox area that can be tapped in Wallet onboarding initial screen
2 participants