Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix Refresh credentials flow for mobile users #38085

Closed
mattmcalister opened this issue May 6, 2024 · 1 comment · Fixed by brave/brave-core#23725
Closed

[Android] Fix Refresh credentials flow for mobile users #38085

mattmcalister opened this issue May 6, 2024 · 1 comment · Fixed by brave/brave-core#23725
Assignees
Labels
feature/vpn OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include

Comments

@mattmcalister
Copy link

Add a link to Refresh your credentials for both VPN and Leo. See spec.

@mattmcalister mattmcalister added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality feature/vpn labels May 6, 2024
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 23, 2024
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 2, 2024
@hffvld
Copy link
Contributor

hffvld commented Jul 11, 2024

Verified on Galaxy Tab S8 and Pixel 7 using version(s):

Device/OS: 
- Galaxy Tab S8 / gts8wifixx-user 14 UP1A.231005.007 release-keys
- Pixel 7 / panther_beta-user 15 AP31.240517.031 release-keys
Brave build: 1.68.115
Chromium: 127.0.6533.26 (Official Build) beta (64-bit) 

VPN
With existing subscription

STEPS:

  1. Purchase a new VPN subscription on a Desktop, iOS or Android device
  2. If purchased on an iOS or Android device, link the subscription to account.brave.com
  3. Take Android test device > Launch Brave
  4. Hamburger menu > Brave VPN > Verify new strings and the Refresh your credentials button is shown
  5. Tap Refresh your credentials > Enter your email address > Tap Get login link > Verify that link is sent to an email
  6. Go to email and tap Confirm your email > Verify account.brave.com is opened, and the Success! message is shown
  7. Hamburger menu > Brave VPN > Install VPN Profile > Verify

ACTUAL RESULTS:

  • Verified that new text is shown below the Monthly subscription button
  • Verified that the new Refresh your credentials button is shown and working
  • Verified that the restore link is sent to email
  • Verified that the Confirm your email link is working, account.brave.com opened, and the Success! message shown
  • Verified that the VPN subscription can be linked and enabled successfully

Galaxy Tab S8

2024-07-11_16-01-31.mp4

Pixel 7

1 2 3 4
1 2 3 4
1 2 3 4
2024-07-11_13-21-29.mp4
Without existing subscription

STEPS:

  1. Don't purchase VPN subscription
  2. Take the Android test device > Launch Brave
  3. Hamburger menu > Brave VPN > Verify new strings and the Refresh your credentials button is shown
  4. Tap Refresh your credentials > Enter your email address > Tap Get login link > Verify that link is sent to an email
  5. Go to email and tap Confirm your email > Verify account.brave.com is opened, and a warning message is shown

ACTUAL RESULTS:

  • Verified that We couldn't find a subscription associated with your email address. message is shown on the account.brave.com page if no active VPN subscription is found for that account.

2024-07-11_16-15-32.mp4
Leo
With existing subscription

STEPS:

  1. Purchase a new Leo subscription on a Desktop, iOS or Android device
  2. If purchased on an iOS or Android device, link the subscription to account.brave.com
  3. Take Android test device > Launch Brave
  4. Hamburger menu > Settings
  5. Leo > Go Premium > Verify new strings and the Refresh your credentials button is shown
  6. Tap Refresh your credentials > Enter your email address > Tap Get login link > Verify that link is sent to an email
  7. Go to email and tap Confirm your email > Verify account.brave.com is opened, and the Success! message is shown
  8. Open Leo > Verify that Premium account is shown

ACTUAL RESULTS:

  • Verified that new text is shown below the Monthly subscription button
  • Verified that the new Refresh your credentials button is shown and working
  • Verified that the restore link is sent to email
  • Verified that the Confirm your email link is working, account.brave.com opened, and the Success! message shown
  • Verified that the VPN subscription can be linked and enabled successfully

Galaxy Tab S8

1 2 3 4
1 2 3 4
2024-07-11_17-40-53.1.mp4

Pixel 7

2024-07-11_18-03-35.mp4
Without existing subscription

STEPS:

  1. Don't purchase a Leo subscription
  2. Take the Android test device > Launch Brave
  3. Hamburger menu > Settings
  4. Leo > Go Premium > Verify new strings and the Refresh your credentials button is shown
  5. Tap Refresh your credentials > Enter your email address > Tap Get login link > Verify that link is sent to an email
  6. Go to email and tap Confirm your email > Verify account.brave.com is opened, and a warning message is shown

ACTUAL RESULTS:

  • Verified that We couldn't recover your credentials for Leo Premium since the subscription is not paid. message is shown on the account.brave.com page if no active Leo subscription is found for that account.
2024-07-11_16-54-30.mp4

@hffvld hffvld added QA Pass - Android ARM QA Pass - Android Tab and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/vpn OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants