-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New restore subscription android #23725
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
android/java/org/chromium/chrome/browser/brave_leo/BraveLeoPlansActivity.java
Outdated
Show resolved
Hide resolved
Just a general question: how does it suppose to look when a user has mobile only purchase? Do we always show the restore button? As I don't think we can restore credentials if the account isn't linked. |
android/java/org/chromium/chrome/browser/brave_leo/BraveLeoPlansActivity.java
Outdated
Show resolved
Hide resolved
3fc00ba
to
bd573b4
Compare
bd573b4
to
42c09c2
Compare
android/java/org/chromium/chrome/browser/settings/BraveLeoPreferences.java
Show resolved
Hide resolved
42c09c2
to
2502ca5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strings
++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Update changes to open url with TabUtils
Remove unused variables
2502ca5
to
52de317
Compare
[puLL-Merge] - brave/brave-core@23725 DescriptionThis PR makes several changes related to subscription linking and management for the Brave browser's VPN and AI chat (Leo) features on Android. It updates UI elements on the subscription plans pages, adds new utility functions for handling subscription linking, and removes some unused code. ChangesChanges
Security HotspotsNone found. The changes do not appear to introduce any new security risks. |
Resolves brave/brave-browser#38085
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Please reach out to @deeppandya for more details on testing