Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Update search engine default for IT #38192

Closed
iccub opened this issue May 9, 2024 · 4 comments · Fixed by brave/brave-core#23539
Closed

[iOS] Update search engine default for IT #38192

iccub opened this issue May 9, 2024 · 4 comments · Fixed by brave/brave-core#23539
Assignees
@iccub
Labels
Brave Search feature/search l10n OS/iOS Fixes related to iOS browser functionality QA Pass - iPad QA Pass - iPhone QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.67.x - Release

Comments

@iccub
Copy link

iccub commented May 9, 2024

Desktop issue: #38028
@iccub iccub added OS/iOS Fixes related to iOS browser functionality QA/Yes labels May 9, 2024
This was referenced May 9, 2024
Merged
Closed
iccub added a commit to brave/brave-core that referenced this issue May 9, 2024
@iccub
[iOS] Make Brave Search default in Italy region.
ae127d3 
Resolves brave/brave-browser#38192
iccub added a commit to brave/brave-core that referenced this issue May 9, 2024
@iccub
[iOS] Make Brave Search default in Italy region. (#23539)
2a0d5f6 
Resolves brave/brave-browser#38192
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 9, 2024
@brave-builds brave-builds mentioned this issue May 10, 2024
Merged
7 tasks
@iccub iccub mentioned this issue May 20, 2024
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Jun 6, 2024

The above requires 1.67.109 or higher for 1.67.x verification 👍

@kjozwiak
Copy link
Member

kjozwiak commented Jun 6, 2024

@Uni-verse @hffvld we'll need to check both iPhone & iPad using the template from brave/brave-core#23539 (comment). We'll need to run through the following:

@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 14, 2024
@Uni-verse
Copy link
Contributor

Uni-verse commented Jun 14, 2024 •
edited
Loading

Verified on iPhone 12 running iOS 17.3.1 using version 1.67.115

IT (Italy) - PASSED

Clean profile
  • ensured that Brave Search was selected as the default for both Standard/Private tab via Search Engines in Settings
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Standard tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Private tab
Example Example Example
IMG_6392 IMG_6393 IMG_6394
Updated Profile (Google/Google)
  • installed 1.66.x
  • ensured that Google was the default SE selected under Search Engines for both Standard & Private tab
  • updated to 1.67.115 and ensured that Google is still the default SE for Standard & Private tabs
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Standard tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Private tab
  • ensured Google search is used when searching from the omnibar
1.66 1.67.115
IMG_6395 IMG_6398
IMG_6396 IMG_6399
IMG_6397 IMG_6400
Updated Profile (Bing/Ecosia)
  • installed 1.66
  • changed the default SE to Bing under Search Engines for Standard tab
  • changed the default SE to Ecosia under Search Engines for Private tab
  • updated to 1.67.115
  • ensured that Bing wasn't replaced with Brave Search as the default SE for Standard tab
  • ensured that Ecosia wasn't replaced with Brave Search as the default SE for Private tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Standard tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Private tab
1.66 1.67.115
IMG_6402 IMG_6403

FR (France) - PASSED

Clean Profile
  • ensured that Brave Search was selected as the default for both Standard/Private tab via Search Engines in Settings
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Standard tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Private tab
Example Example Example
IMG_6411 IMG_6412 IMG_6413
Updated Profile (Brave/Brave)
  • installed 1.66
  • ensured that Brave Search was the default SE selected under Search Engines for both Standard & Private tab
  • updated to 1.67.115 and ensured that Brave Search is still the default SE for Standard & Private
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Standard tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Private tab
Example Example
IMG_6414 IMG_6415
Updated Profile (Bing/DDG)
  • installed 1.66
  • changed the default SE to DDG under Search Engines for Standard tab
  • changed the default SE is Startpage under Search Engines for Private tab
  • updated to 1.67.115
  • ensured that DDG wasn't replaced with Brave Search as the default SE for Standard tab
  • ensured that Startpage wasn't replaced with Brave Search as the default SE for Private tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Standard tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Private tab
Example Example
IMG_6416 IMG_6417

SV_SE (Sweden) - PASSED

Clean Profile
  • ensured that Google was selected as the default for both Standard/Private tab via Search Engines in Settings
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Standard tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Private tab
Example Example Example
IMG_6404 IMG_6405 IMG_6406
Updated Profile (Google/Google)
  • installed 1.66
  • ensured the default SE is Google under Search Engines for Standard tab
  • ensured the default SE is Google under Search Engines for Private tab
  • updated to 1.67.115
  • ensured that Google wasn't replaced with Brave Search as the default SE for Standard tab
  • ensured that Google wasn't replaced with Brave Search as the default SE for Private tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Standard tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Private tab
1.66 1.67.115
IMG_6407 IMG_6408
Updated Profile (DDG/Startpage)
  • installed 1.66
  • changed the default SE to DDG under Search Engines for Standard tab
  • changed the default SE is Startpage under Search Engines for Private tab
  • updated to 1.67.115
  • ensured that DDG wasn't replaced with Brave Search as the default SE for Standard tab
  • ensured that Startpage wasn't replaced with Brave Search as the default SE for Private tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Standard tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Private tab
Example Example
IMG_6409 IMG_6410

@Uni-verse
Copy link
Contributor

Uni-verse commented Jun 17, 2024 •
edited
Loading

Verified on iPad (7th Gen) running iOS 17.4 using version 1.67.115

IT (Italy) - PASSED

Clean profile
  • ensured that Brave Search was selected as the default for both Standard/Private tab via Search Engines in Settings
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Standard tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Private tab
Example Example Example
IMG_1426 IMG_1427 IMG_1428
Updated Profile (Google/Google)
  • installed 1.66.x
  • ensured that Google was the default SE selected under Search Engines for both Standard & Private tab
  • updated to 1.67.115 and ensured that Google is still the default SE for Standard & Private tabs
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Standard tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Private tab
  • ensured Google search is used when searching from the omnibar
1.66 1.67.115
IMG_1429 2 IMG_1430 2
Updated Profile (Bing/Ecosia)
  • installed 1.66
  • changed the default SE to Bing under Search Engines for Standard tab
  • changed the default SE to Ecosia under Search Engines for Private tab
  • updated to 1.67.115
  • ensured that Bing wasn't replaced with Brave Search as the default SE for Standard tab
  • ensured that Ecosia wasn't replaced with Brave Search as the default SE for Private tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Standard tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Private tab
1.66 1.67.115
IMG_1431 2 IMG_1432 2

FR (France) - PASSED

Clean Profile
  • ensured that Brave Search was selected as the default for both Standard/Private tab via Search Engines in Settings
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Standard tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Private tab
Example Example Example
IMG_1433 IMG_1434 IMG_1435
Updated Profile (Brave/Brave)
  • installed 1.66
  • ensured that Brave Search was the default SE selected under Search Engines for both Standard & Private tab
  • updated to 1.67.115 and ensured that Brave Search is still the default SE for Standard & Private
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Standard tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Private tab
Example Example
IMG_1437 IMG_1436
Updated Profile (Bing/DDG)
  • installed 1.66
  • changed the default SE to DDG under Search Engines for Standard tab
  • changed the default SE is Startpage under Search Engines for Private tab
  • updated to 1.67.115
  • ensured that DDG wasn't replaced with Brave Search as the default SE for Standard tab
  • ensured that Bing wasn't replaced with Brave Search as the default SE for Private tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Standard tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Private tab
Example Example
IMG_1439 IMG_1440

SV_SE (Sweden) - PASSED

Clean Profile
  • ensured that Google was selected as the default for both Standard/Private tab via Search Engines in Settings
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Standard tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Private tab
Example Example Example
IMG_1441 IMG_1442 IMG_1443
Updated Profile (Google/Google)
  • installed 1.66
  • ensured the default SE is Google under Search Engines for Standard tab
  • ensured the default SE is Google under Search Engines for Private tab
  • updated to 1.67.115
  • ensured that Google wasn't replaced with Brave Search as the default SE for Standard tab
  • ensured that Google wasn't replaced with Brave Search as the default SE for Private tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Standard tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Private tab
1.66 1.67.115
IMG_1444 IMG_1445
Updated Profile (DDG/Startpage)
  • installed 1.66
  • changed the default SE to DDG under Search Engines for Standard tab
  • changed the default SE is Startpage under Search Engines for Private tab
  • updated to 1.67.115
  • ensured that DDG wasn't replaced with Brave Search as the default SE for Standard tab
  • ensured that Startpage wasn't replaced with Brave Search as the default SE for Private tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Standard tab
  • ensured that Brave Search was the first engine via the drop down list under Search Engines for Private tab
Example Example
IMG_1446 2 IMG_1447 2

@Uni-verse Uni-verse added QA Pass - iPad and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 17, 2024
@kjozwiak kjozwiak mentioned this issue Jun 25, 2024
Closed
9 tasks
@Uni-verse Uni-verse mentioned this issue Jul 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iccub iccub

Labels
Brave Search feature/search l10n OS/iOS Fixes related to iOS browser functionality QA Pass - iPad QA Pass - iPhone QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.67.x - Release
Development

Successfully merging a pull request may close this issue.

[iOS] Make Brave Search default in Italy region. brave/brave-core
4 participants
@kjozwiak @iccub @Uni-verse @brave-builds