Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown site favicon for few publishers #4016

Closed
GeetaSarvadnya opened this issue Apr 5, 2019 · 7 comments
Closed

Unknown site favicon for few publishers #4016

GeetaSarvadnya opened this issue Apr 5, 2019 · 7 comments

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 5, 2019

Description

I have been using the Nightly build as my personal profile for a few days ( since 3 days). I have opened a few YT and Twitch videos along with websites. Around 35 sites got added to a-c table. On the 3rd day, I am seeing unknown site favicon for a few publishers for e.g (Brave.com and Twitch pubs). I have reloaded the brave.com couple of times and correct favicon retained back in a-c table, but for twitch unknown favicon remained unchanged even after the page reload.

Steps to Reproduce

  1. Open brave 0.65.16
  2. Enable Rewards
  3. Open Random websites including YT and Twitch ( used the same profile for 3 days)
  4. Unknown favicon is shown for a few publishers

Actual result:

image

Expected result:

Correct favicon should be displayed

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.65.16 Chromium: 74.0.3729.40 (Official Build) nightly (64-bit)
Revision 278d6a0d856d8314f36fb9a68b6e1d85cd0d14e7-refs/branch-heads/3729@{#470}
OS Windows 10 OS Build 17134.523

Reproducible on current release: No

  • Does it reproduce on brave-browser dev/beta builds? No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional Information

@brave/legacy_qa

@GeetaSarvadnya GeetaSarvadnya added bug feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Apr 5, 2019
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Apr 5, 2019

@GeetaSarvadnya can you please inspect the icon and let me know what the url is? Thank you

@GeetaSarvadnya
Copy link
Author

@NejcZdovc Please find the below screen.

image

@NejcZdovc
Copy link
Contributor

@GeetaSarvadnya I would need the icon as well, thank you

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Apr 9, 2019

@NejcZdovc Please find the icon/favicon source as well

image

@NejcZdovc
Copy link
Contributor

all links look good. if you click on the link and then check again (refresh rewards page), do you see the image? Maybe chromium didn't fetch it

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Apr 9, 2019

@NejcZdovc Click on the link and multiple page reload (brave://rewards) resolved the issue. But site favicon should retain in a-c table without page reload.

image

@NejcZdovc
Copy link
Contributor

this link is from chromium, so we can't do anything about it if it's not stored int chromium favicon storage. Closing it

@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Apr 9, 2019
@NejcZdovc NejcZdovc added closed/wontfix closed/not-actionable and removed bug priority/P5 Not scheduled. Don't anticipate work on this any time soon. closed/wontfix labels Apr 9, 2019
@kjozwiak kjozwiak removed this from the Dupe / Invalid / Not actionable milestone Apr 11, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants