Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 128.0.6613.40 to Chromium 128.0.6613.85 #40586

Closed
mkarolin opened this issue Aug 21, 2024 · 8 comments · Fixed by brave/brave-core#25272
Closed

Upgrade from Chromium 128.0.6613.40 to Chromium 128.0.6613.85 #40586

mkarolin opened this issue Aug 21, 2024 · 8 comments · Fixed by brave/brave-core#25272

Comments

@mkarolin
Copy link
Contributor

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/128.0.6613.40..128.0.6613.85?pretty=fuller&n=10000

QA tests

  • Check branding items
  • Check for version bump

Minor Chromium bump

  • No specific code changes in Brave (only line number changes in patches)
@kjozwiak
Copy link
Member

The above requires 1.69.153 or higher for 1.69.x verification 👍

@kjozwiak kjozwiak added OS/iOS Fixes related to iOS browser functionality QA/Test-All-Platforms labels Aug 22, 2024
@kjozwiak
Copy link
Member

Quick overview of the work remaining re: affected areas due to C128 on the following platforms:

Platforms that only require a spot check due to already completing full check of the affected areas mentioned via #39083 (comment):

Platforms that still need to check/verify the affected areas due to C128 changes as per #39083 (comment):

  • iOS - Affected Areas still needs to be checked/verified

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.69.153 Chromium: 128.0.6613.85 (Official Build) (64-bit)
-- | --
Revision | a69e96756922f88cbce3482971d70cfd1ee6f872
OS | Windows 10 Version 22H2 (Build 19045.4780)

image

@LaurenWags
Copy link
Member

Verified with

Brave | 1.69.153 Chromium: 128.0.6613.85 (Official Build) (x86_64)
-- | --
Revision | a69e96756922f88cbce3482971d70cfd1ee6f872
OS | macOS Version 13.6.9 (Build 22G830)
Screenshot 2024-08-22 at 8 58 51 AM

Verified with

Brave	1.69.153 Chromium: 128.0.6613.85 (Official Build) (arm64) 
Revision	a69e96756922f88cbce3482971d70cfd1ee6f872
OS	macOS Version 14.6.1 (Build 23G93)
Screenshot 2024-08-22 at 9 01 11 AM

@btlechowski
Copy link

Verified with

Brave 1.69.153 Chromium: 128.0.6613.85 (Official Build) (64-bit)
Revision a69e96756922f88cbce3482971d70cfd1ee6f872
OS Linux

image

@Uni-verse
Copy link
Contributor

Uni-verse commented Aug 22, 2024

Verified on Samsung Galaxy S21 using version:

Brave	1.69.153 Chromium: 128.0.6613.85 (Official Build) (64-bit) 
Revision	a69e96756922f88cbce3482971d70cfd1ee6f872
OS	Android 13; Build/TP1A.220624.014; 33; REL
Example Example
Screenshot 2024-08-22 at 10 14 12 AM Screenshot 2024-08-22 at 10 14 29 AM

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy Tab S7 using version:

Brave	1.69.153 Chromium: 128.0.6613.85 (Official Build) (64-bit) 
Revision	a69e96756922f88cbce3482971d70cfd1ee6f872
OS	Android 13; Build/TP1A.220624.014; 33; REL
Example Example
Screenshot 2024-08-22 at 10 43 09 AM Screenshot 2024-08-22 at 10 43 21 AM

@hffvld
Copy link
Contributor

hffvld commented Aug 28, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.6.1
Brave build: 1.69 (157)
BraveCore: 1.69.157 (128.0.6613.85)

Filed follow-up issues #40743 and #40744 which are not related to the Chromium upgrade.

Bookmarks + exporting

ACTUAL RESULTS:

  • Verified that bookmarks can be added, removed and edited
  • Verified that bookmarks export and import works as expected
  • Verified that new folder can be created in bookmarks
  • Verified that multiple bookmarks can be saved as a batch

1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
Password saving

ACTUAL RESULTS:

  • Verified that new login and password credentials can be saved
  • Verified that saved login and password credentials can be used to log in to a website
  • Verified that saved login credentials can be edited or deleted

1 2 3
1 2 3
1 2 3
1 2 3
Private mode works

ACTUAL RESULTS:

  • Verified that Private tabs works
  • Verified that Private tabs can be locked with a password
  • Verified that Private tabs can be saved on Brave relaunch

1 2 3
1 2 3
1 2 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment