Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CR130] Fix override for progress bar color on downloads page #41153

Open
emerick opened this issue Sep 19, 2024 · 0 comments
Open

[CR130] Fix override for progress bar color on downloads page #41153

emerick opened this issue Sep 19, 2024 · 0 comments
Labels
Chromium/Followup Followup work logged during Chromium rebase dev-concern

Comments

@emerick
Copy link
Contributor

emerick commented Sep 19, 2024

Description

The override for the progress bar color on brave://downloads hasn't been working for several releases and, with the switch to Lit, it's no longer compiling at all. After speaking with @fallaciousreasoning, decided that the simplest way forward is to remove the override and fix it in master once cr130 is merged.
@emerick emerick added dev-concern Chromium/Followup Followup work logged during Chromium rebase labels Sep 19, 2024
emerick added a commit to brave/brave-core that referenced this issue Sep 19, 2024
@emerick
Remove non-functional override for progress bar color on downloads page
741b3ab 
This hasn't been working for several releases and, with the switch to Lit, it's
no longer compiling. After speaking with Jay, decided that the simplest way
forward is to remove the override and fix it in master once cr130 is merged.

Tracked via brave/brave-browser#41153
emerick added a commit to brave/brave-core that referenced this issue Sep 20, 2024
@emerick
Remove non-functional override for progress bar color on downloads page
6c9117c 
This hasn't been working for several releases and, with the switch to Lit, it's
no longer compiling. After speaking with Jay, decided that the simplest way
forward is to remove the override and fix it in master once cr130 is merged.

Tracked via brave/brave-browser#41153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Chromium/Followup Followup work logged during Chromium rebase dev-concern
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emerick