Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cases where span is returning a dead value #42185

Closed
cdesouza-chromium opened this issue Nov 9, 2024 · 0 comments · Fixed by brave/brave-core#26461
Closed

Fix cases where span is returning a dead value #42185

cdesouza-chromium opened this issue Nov 9, 2024 · 0 comments · Fixed by brave/brave-core#26461

Comments

@cdesouza-chromium
Copy link
Contributor

Description

There seems to be a few cases in the codebase at the moment where we are having dangling access to values that have been disposed of.

@cdesouza-chromium cdesouza-chromium self-assigned this Nov 9, 2024
cdesouza-chromium added a commit to brave/brave-core that referenced this issue Nov 9, 2024
This PR fixes cases where a local constant is being used to initialise a
`span` but then the span is being used by the time the local has already
been discarded. This is undefined behaviour although in both cases it
seems to be incidently working.

Resolve brave/brave-browser#42185
cdesouza-chromium added a commit to brave/brave-core that referenced this issue Nov 9, 2024
This PR fixes cases where a local constant is being used to initialise a
`span` but then the span is being used by the time the local has already
been discarded. This is undefined behaviour although in both cases it
seems to be incidently working.

Resolve brave/brave-browser#42185
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants