Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different number of scripts blocked in main view and detailed view #4228

Closed
btlechowski opened this issue Apr 25, 2019 · 2 comments · Fixed by brave/brave-core#2485
Closed
Assignees
Labels
design A design change, especially one which needs input from the design team feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@btlechowski
Copy link

btlechowski commented Apr 25, 2019

Steps to Reproduce

  1. Open https://www.poboczem.pl/video,vId,2681150
  2. Open Shields Panel
  3. Blocked the scripts

Actual result:

Different number of scripts blocked in main view and detailed view
Main view shows 18 scripts blocked:
image
Detailed view shows 3 scripts blocked
image

Expected result:

The same number of scripts blocked in main view and detailed view

Edit: The detailed view does not show actual scripts blocked, but it shows domains only. Maybe we should rename Scripts blocked to Domains blocked.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.64.60 Chromium: 74.0.3729.91 (Official Build) beta (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Windows 10 OS Build 17134.523

cc @brave/legacy_qa @tomlowenthal

@btlechowski btlechowski added feature/shields The overall Shields feature in Brave. design A design change, especially one which needs input from the design team QA/Yes QA/Test-Plan-Specified feature/shields/panel Front-end design and functionality of the Shields panel. labels Apr 25, 2019
@srirambv
Copy link
Contributor

This has always been the behaviour. Was briefly discussed here https://bravesoftware.slack.com/archives/CD495CWLR/p1548828086062300

cc: @karenkliu

@karenkliu
Copy link

The block count should count individual scripts blocked both on the main panel and scripts detail view. Detail view of scripts should have a matching number. @cezaraugusto mentioned he is able to show each individual script now, so that will help clear up the confusion; if there are 18 blocked scripts the user can go into the scripts detail view to see 18 items listed.

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Apr 26, 2019
cezaraugusto added a commit to brave/brave-core that referenced this issue May 23, 2019
-
scripts now use the same method for checking scripts blocked
fix brave/brave-browser#4228
cezaraugusto added a commit to brave/brave-core that referenced this issue May 27, 2019
-
scripts now use the same method for checking scripts blocked
fix brave/brave-browser#4228
bsclifton pushed a commit to brave/brave-core that referenced this issue Jun 5, 2019
-
scripts now use the same method for checking scripts blocked
fix brave/brave-browser#4228
@cezaraugusto cezaraugusto added this to the 0.68.x - Nightly milestone Jun 7, 2019
@btlechowski
Copy link
Author

btlechowski commented Jul 31, 2019

Awesome work!

Verification passed on

Brave 0.68.113 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Ubuntu 18.04 LTS

Used test plan from brave/brave-core#2485
Used test plan from the description.
There were 19 blocked scripts in main panel and 19 scripts listed in detailed view
image
image

Verification passed on

Brave 0.68.116 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Windows 10 OS Version 1803 (Build 17134.523)

image

image

Verified passed with

Brave 0.68.118 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
7 participants