Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable motion sensors on desktop #4789

Closed
pes10k opened this issue Jun 10, 2019 · 3 comments
Closed

Disable motion sensors on desktop #4789

pes10k opened this issue Jun 10, 2019 · 3 comments
Assignees
Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields feature/shields The overall Shields feature in Brave. priority/P3 The next thing for us to work on. It'll ride the trains. privacy/tracking Preventing sites from tracking users across the web privacy QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@pes10k
Copy link
Contributor

pes10k commented Jun 10, 2019

Test plan

See brave/brave-core#2802

Description

Currently Brave enables the motion sensor APIs by default
Screen Shot 2019-06-10 at 3 17 18 PM

Brave blocks motion sensors on Android by default currently (https://github.com/brave/browser-android-tabs/issues/1669). Would be good to disable on desktop too by default. Most of the time it'll be a no-op, but would be relevant on some systems (e.g. tablets).

Low web compat risk since most other browsers don't support: https://caniuse.com/#search=sensor

@pes10k pes10k added feature/shields The overall Shields feature in Brave. privacy privacy/tracking Preventing sites from tracking users across the web feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields labels Jun 10, 2019
@tildelowengrimm tildelowengrimm added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 10, 2019
@tildelowengrimm tildelowengrimm changed the title Disable motion sensions on desktop Disable motion sensors on desktop Jun 12, 2019
@fmarier
Copy link
Member

fmarier commented Jun 25, 2019

@bsclifton bsclifton removed this from the 0.72.x - Nightly milestone Sep 24, 2019
@bsclifton
Copy link
Member

Re-opening after brave/brave-core#2802 was reverted with brave/brave-core#3517

@btlechowski
Copy link

btlechowski commented Oct 28, 2019

Verification passed on

Brave 0.72.110 Chromium: 78.0.3904.70 (Official Build) dev (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#2802
image
image

Verified that Motion Sensors are off by default on clean profile and upgrade from 0.70.x
image

Verified passed with

Brave 0.72.110 Chromium: 78.0.3904.70 (Official Build) dev (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS macOS Version 10.13.6 (Build 17G5019)

4709

both

Verification passed on

Brave 1.1.1 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields feature/shields The overall Shields feature in Brave. priority/P3 The next thing for us to work on. It'll ride the trains. privacy/tracking Preventing sites from tracking users across the web privacy QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Development

No branches or pull requests

7 participants