New tab page background setting should be a profile preference #5064
Assignees
Labels
Milestone
Comments
bsclifton
pushed a commit
to brave/brave-core
that referenced
this issue
Jun 28, 2019
…tead of localStorage Fixes brave/brave-browser#5064 This allows: - Surfacing these preferences outside of the NTP - Syncing / migrating the preferences - Making the change immediately for all open NTP Use FireWebUIListener to push data to javascript event subscribers. Still uses render_view_host->SetWebUIProperty (like the existing NTP data), which we may port in the future to a DataSource Dictionary like the other WebUI in chromium. Provides any data retreived or updated to redux store via redux action, but does not use redux actions to ask for a data change.
petemill
added a commit
to brave/brave-core
that referenced
this issue
Jun 28, 2019
…tead of localStorage This allows: - Surfacing these preferences outside of the NTP - Syncing / migrating the preferences - Making the change immediately for all open NTP Use FireWebUIListener to push data to javascript event subscribers. Still uses render_view_host->SetWebUIProperty (like the existing NTP data), which we may port in the future to a DataSource Dictionary like the other WebUI in chromium. Provides any data retreived or updated to redux store via redux action, but does not use redux actions to ask for a data change. Fix brave/brave-browser#5064
32 tasks
petemill
added a commit
to brave/brave-core
that referenced
this issue
Jun 28, 2019
…tead of localStorage This allows: - Surfacing these preferences outside of the NTP - Syncing / migrating the preferences - Making the change immediately for all open NTP Use FireWebUIListener to push data to javascript event subscribers. Still uses render_view_host->SetWebUIProperty (like the existing NTP data), which we may port in the future to a DataSource Dictionary like the other WebUI in chromium. Provides any data retreived or updated to redux store via redux action, but does not use redux actions to ask for a data change. Fix brave/brave-browser#5064
|
Verification passed on
Used test plan from brave/brave-core#2831
Verification passed on
Verified passed with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Test plan
See brave/brave-core#2831
Description
The backgrounds on the new tab page were made toggleable with brave/brave-core#2668, however the setting is persisted only in local storage
Additional notes
This setting should be defaulted to ON
When brave/brave-core#2668 was implemented, it defaulted to OFF. This was fixed with brave/brave-core#2756... but users that got this (between versions 68.64 and 68.72) would still have backgrounds OFF
Adding this new setting will fix those users
The text was updated successfully, but these errors were encountered: