Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options to suppress Widevine notification #5068

Closed
tildelowengrimm opened this issue Jun 28, 2019 · 10 comments
Closed

Options to suppress Widevine notification #5068

tildelowengrimm opened this issue Jun 28, 2019 · 10 comments
Assignees
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. plugin/Widevine

Comments

@tildelowengrimm
Copy link
Contributor

The Widevine install notification should have more options to dismiss it so that someone isn't constantly barraged by Widevine install notifications on a site they know they don't want to see.

[This section subject to design adjustment. Specifics can change, functionality should remain].
Add a checkbox on the Widevine prompt, with a drop-down picker:
[ ] Never ask me again [ on this site | on any site ]

If checked, "this site" means any page under this eTLD+1.

We also need a way to undo this choice in settings. If you really want to undo it, you probably don't want to be prompted again, so it should just be an option to install Widevine directly. In the Extensions section of settings:

Legend: Install the Widevine DRM module >
Explanation: Widevine is a piece of copy protection software from Google which some sites use to play protected video.

Clicking this option gives you a modal dialog (like the one for Reset Settings):

Title: Install Widevine
Body: Google's Widevine is a piece of copy protection software sometimes euphemistically called "digital rights management" or DRM. Brave doesn't own or control Widevine, we can't inspect it, and we can't promise it's safe to use. Some sites require Widevine in order to play back protected video. You have to agree to the Widevine [Terms of Use] from Google before installing it.
Buttons: [ Cancel ] [[ Install Widevine ]]

@tildelowengrimm tildelowengrimm added design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. priority/P4 Planned work. We expect to get to it "soon". plugin/Widevine labels Jun 28, 2019
@shapeshifterincontext
Copy link

Yes please.
Example: using a website like Aliexpress, where I can have 50 tabs open in a matter of minutes, drives me absolutely insane!

@tinfever
Copy link

I'd like to second this request. Aliexpress asks for this on every tab. It'd be great to be able to say "No" and have an option for the domain to not ask again.

@misterkatanga
Copy link

I love this browser but I need to use Aliexpress for my business so this bug is a dealbreaker for me. Aliexpress is one of the most frequented online shopping sites. Not addressing this in any way is a bad sign to me. I can already see this issue was brought up some time ago and was summarily closed with zero attempt to fix the issue.

I really hope I am wrong and this is addressed soon.

@simonhong simonhong self-assigned this Jul 23, 2019
@simonhong simonhong added this to the 0.69.x - Nightly milestone Jul 23, 2019
@simonhong simonhong removed this from the 0.69.x - Nightly milestone Jul 23, 2019
@simonhong
Copy link
Member

simonhong commented Jul 23, 2019

PR(#5341) for simple version that just added don't ask again in install prompt is pushed because more specs are needed for this issue. I'll handle when it's done.

@whraglyn
Copy link

Hi Simon,
Plz excuse this probably unnecessary query from an old 100% disabled man who lives to newsurf, and is getting pretty damn tired of continual widevine notices.

Any progress on 'do not ask again'/'never ask' checkbox for such notices?

Many thx for all your hard work on Brave, Simon, as to all who are with you, Sir.

Scotty :-)

WIDEVINE

@simonhong
Copy link
Member

simonhong commented Sep 24, 2019

@whraglyn You will see Don't ask again check box in the next release (0.69.x) :)
brave/brave-core#2980

@whraglyn
Copy link

whraglyn commented Sep 24, 2019 via email

@simonhong
Copy link
Member

@whraglyn Sorry for your inconvenience.
Waiting to next stable release is only the option.
We are planning to release it at October 1, 2019. release schedule
After that, you can shut down it from dialog or settings.
Thanks!

@whraglyn
Copy link

whraglyn commented Sep 25, 2019 via email

@Techguyprivate
Copy link

tmancey pushed a commit that referenced this issue Apr 9, 2020
@rebron rebron added closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. and removed design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. priority/P4 Planned work. We expect to get to it "soon". labels Mar 22, 2022
@rebron rebron closed this as completed Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. plugin/Widevine
Projects
None yet
Development

No branches or pull requests

8 participants