Add switch to disable WebRTC

[jumde]

No description provided.

[bbondy]

Is this different from fingerprinting protection which I think already does this?

[jumde]

Block All fingerprinting does disable WebRTC but, after a reddit discussion the webrtc options was moved to a site setting in case the user does not Block All Fingerprinting since it does break some known sites. See: brave/browser-laptop#13668

[jumde]

https://whoer.net/ - Shows WebRTC leaks even with Block All Fingerprinting

[yrliou]

Block All fingerprinting does not disable WebRTC entirely, it only make methods that could be causing IP leaks act similar as no-op.
I suppose the original idea of adding this switch in browser-laptop is users could have a way to disable WebRTC without turning on Block All Fingerprinting which might break sites.

I just quickly checked the website, the result is as follows.

It does prevent IP leakage and has the same result of Block All fingerprinting in browser-laptop.
@jumde Could you point me where the test showing us having the WebRTC leak so I could check on my end?

[jumde]

@yrliou - WebRTC is blocked on whoer.net, I think the page did not reload correctly, and so it was still showing the IP address. Sorry about that.

Re: -

I suppose the original idea of adding this switch in browser-laptop is users could have a way to disable WebRTC without turning on Block All Fingerprinting which might break sites.

We should probably do the same in brave-core

[jumde]

This is available on browser-laptop

[eljuno]

+1 from community https://community.brave.com/t/brave-dev-is-excellent-with-chrome-addons-but-what-addons-you-use/31625?u=eljuno

Brave Dev doesnot have control over webRTC leak as Brave regular.

[Brave-Matt]

+1 from Community:
https://community.brave.com/t/any-suggestion-to-stop-webrtc-leak-with-brave-dev-browser/32114/3

[rebron]

@bradleyrichter We have another setting that needs a landing place. Right below safe browsing and before crash reports.

In between these two settings looks to make the most sense.

[yrliou]

Please see brave/brave-core#538 for the test plan, thanks.

[srirambv]

Verification Passed on

Brave	0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision	28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS	Linux

• Verified WebRTC policy is listed under Privacy settings
• Verified Default WebRTC setting shows IP as expected
• Verified Default public and private interfaces setting shows IP as expected
• Verified Disable non-proxied UDP blocks all IP as expected

Verified passed with

Brave	0.55.11 Chromium: 70.0.3538.35 (Official Build) beta(64-bit)
Revision	28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS	Mac OS X

*Verified via test plan supplied in #551 (comment)

Verification passed on

Brave	0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision	28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS	Windows 7