Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Media Box to GitHub inline tipping banner #5562

Closed
jdkuki opened this issue Aug 6, 2019 · 0 comments
Closed

Add Media Box to GitHub inline tipping banner #5562

jdkuki opened this issue Aug 6, 2019 · 0 comments
Labels
feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon.

Comments

@jdkuki
Copy link

jdkuki commented Aug 6, 2019

Description

When a tip button is clicked, it opens a dialog to tip the user. For Reddit and Twitter, a Media Box containing the post content is also in the banner. This should be added for GitHub.

cc @alexwykoff @jenn-rhim

Steps to Reproduce

Actual result:

image
N/A

Expected result:

(Equivalent for GitHub)
image

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@NejcZdovc NejcZdovc added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Sep 20, 2019
@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
None yet
Development

No branches or pull requests

3 participants