-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
seek (forward or backward) on vimeo video messes up entire AC table #5725
Comments
Note - if at step 8 you remove this publisher from your AC table, your previous entries come back. |
Reproduced on Ubuntu
|
The issue is Reproducible in windows |
Additional notes:
|
@NejcZdovc here are some simpler steps:
|
Verified passed with
Verification passed on
Verification passed on
|
Description
Found while testing #4017
If you watch a vimeo video normally, your AC table is fine. However, if you start seeking (forward or backward), the AC table gets really messed up.
Steps to Reproduce
Clean profile on 0.68.x
Enable Rewards (keep this open in one window)
Open a second window and visit some sites - a mix: regular sites, youtube videos, etc.
Watch a vimeo video. See it added to AC table. Note its percentage. If you check
publisher_info_db
at this point, you see normal values for duration, score, etc.Once it's added to the table, move the slider bar forward (essentially fast forwarding the video)
See the % for vimeo video increased on brave://rewards page without actually watching since you fast forwarded. This shouldn't happen.
Move slider bar close to the beginning of the video. See vimeo video removed from AC table. If you check
publisher_info_db
at this point, you could see a negative value for duration (depending on how much of the video you had watched). This shouldn't happen.publisher_info_db
at this point, you will see a normal looking duration, but your score is extremely high.Note - I could not reproduce this with a YouTube video in place of vimeo video.
Actual result:
Seek (forward/backward) on vimeo video screws up ac table.
Expected result:
AC table not wiped out, duration to be accurately recorded.
Reproduces how often:
Seems to reproduce easily with seek forward/backward
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
If you watch vimeo normally this doesn't appear to happen.
The text was updated successfully, but these errors were encountered: