Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Dashboard Settings" icon should be reselected after tabbing through the "Dashboard Settings" items #5871

Open
kjozwiak opened this issue Sep 3, 2019 · 1 comment

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Sep 3, 2019

Description

When tabbing through the Dashboard Settings items, the selector should reselect Dashboard Settings so the user has the chance to close the Dashboard Settings without needing to loop around once more time. Right now, once you're done tabbing through the items via Dashboard Settings, brave://settings/ will be selected

Steps to Reproduce

  1. launch brave and open a NTP
  2. start tabbing through the items until you reach Dashboard Settings
  3. on Dashboard Settings, either press enter or space and you'll notice a new popup modal
  4. tab through those settings and you'll notice that you'll move onto brave://settings and the Dashboard Settings modal is left opened

You'll need to tab through everything once again and press enter or space if you want the Dashboard Settings modal close (see GIF example below).

Actual result:

keyboardTabingNTP

Expected result:

We should probably reselect the Dashboard Setting item after going through the items within Dashboard Settings so the user has the chance to close the popup modal without needing to go around the second time around.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @brave/legacy_qa

@bsclifton
Copy link
Member

Not entirely sure this is a bug - as any website would do that same behavior... User can always use shift + tab to reverse the focus

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants