-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keyboard accessibility to the New Tabs Page settings menu #5041
Labels
bug
feature/new-tab
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/include
Milestone
Comments
This was referenced Jun 26, 2019
imptrx
added a commit
to brave/brave-core
that referenced
this issue
Jun 26, 2019
imptrx
added a commit
to brave/brave-core
that referenced
this issue
Jul 1, 2019
rebron
added
the
priority/P3
The next thing for us to work on. It'll ride the trains.
label
Jul 5, 2019
Marked as blocked until: brave/brave-core#2857 is merged in. |
imptrx
added a commit
to brave/brave-core
that referenced
this issue
Jul 16, 2019
imptrx
added a commit
to brave/brave-core
that referenced
this issue
Jul 19, 2019
… menu is keyboard accessible; closes brave/brave-browser#5041; closes /brave/brave-browser/issues/5199
This was referenced Aug 22, 2019
Verification passed on
Verification passed on
Verification PASSED on
|
rebron
changed the title
New Tabs Page settings menu needs to be keyboard accessible
Add keyboard accessibility to New Tabs Page settings menu
Oct 2, 2019
rebron
changed the title
Add keyboard accessibility to New Tabs Page settings menu
Add keyboard accessibility to the New Tabs Page settings menu
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
feature/new-tab
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/include
Description
If you go through the page you should be able to access the new tabs page settings via keyboard. The settings icon at the bottom left should be selectable.
Steps to Reproduce
Actual result:
The setting button will be skipped over when pressing tab but the other options will not be.
Expected result:
space
orenter
is hitReproduces how often:
Always reproducible.
Test plan:
space
orenter
will open the setting menuspace
orenter
will open the setting menuThe text was updated successfully, but these errors were encountered: