-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash reporting switch state not retained between relaunches #6496
Labels
Milestone
Comments
srirambv
changed the title
Crash reporting switch turned to OFF state after browser restart even though it's turned ON
Crash reporting switch state not retained between relaunches
Oct 16, 2019
Reproduced on Ubuntu 18.04
|
32 tasks
bsclifton
pushed a commit
to brave/brave-core
that referenced
this issue
Oct 21, 2019
Fixes brave/brave-browser#6496 Fixes brave/brave-browser#6497 In places we reused GOOGLE_CHROME_BUILD by defining it in particular files (either via chromium_src or by patching). GOOGLE_CHROME_BUILD is being phased out in favor of BUILDFLAG(GOOGLE_CHROME_BRANDING). This fix updates our uses where the transition has already occurred. Chromium changes: Overall issue tracker: https://bugs.chromium.org/p/chromium/issues/detail?id=961769&can=2&q=961769 Some specific changes: https://chromium.googlesource.com/chromium/src/+/0cc7112944131e379a141d8734a77cb50b97e1d5 commit 0cc7112944131e379a141d8734a77cb50b97e1d5 Author: Nico Weber <thakis@chromium.org> Date: Mon Jul 29 17:30:40 2019 +0000 Add BUILDFLAG(GOOGLE_CHROME_BRANDING) and start using it in a few places. Also fix the definition of CHROMIUM_BRANDING; putting a negated condition there doesn't work. Thanks to Yngve Petterson for pointing that out. No behavior change. Bug: 961769 https://chromium.googlesource.com/chromium/src/+/356b304474c643e8064db763b97101100597bddd commit 356b304474c643e8064db763b97101100597bddd Author: Nico Weber <thakis@chromium.org> Date: Fri Aug 23 15:30:41 2019 +0000 Remove all references to GOOGLE_CHROME_BUILD in components/ Bug: 961769
This was referenced Oct 22, 2019
Verification passed on
Verified STR from the description. Verified passed with
Verification PASSED on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Description
Crash reporting switch turned to OFF state after browser restart even though it's turned ON
Steps to Reproduce
chrome://settings/
Automatically send crash reports to brave
switch is Turned OFF by defaultRestart
buttonActual result:
After browser restart, the switch is turned OFF
Expected result:
After enabling toggle the switch
Automatically send crash reports to brave
should be in ON state after every browser restartReproduces how often:
Always
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc: @brave/legacy_qa @rebron @bsclifton @kjozwiak
The text was updated successfully, but these errors were encountered: