Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet backup screen should be responsive to browser size #7045

Closed
srirambv opened this issue Nov 20, 2019 · 4 comments · Fixed by brave/ethereum-remote-client#113
Closed
Assignees
Labels
design A design change, especially one which needs input from the design team feature/ethereum-remote-client priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

srirambv commented Nov 20, 2019

Description

Wallet screen should be responsive to browser size

Steps to Reproduce

  1. Have a small browser window than regular
  2. Click on backup code and verify it
  3. All the code words are not shown as the wallet is not responsive to browser window

Actual result:

crypto_zoom

Expected result:

Should be responsive so that the UI is always visible irrespective of browser window size

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.0.1 Chromium: 78.0.3904.108 (Official Build) (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Linux
Crypto Wallet Component: 0.1.29

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@srirambv srirambv added design A design change, especially one which needs input from the design team QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support labels Nov 20, 2019
@srirambv
Copy link
Contributor Author

@bbondy @tomlowenthal can we prioritize this a little higher and have it fixed for the next release?

@tildelowengrimm tildelowengrimm added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 16, 2019
@kjozwiak
Copy link
Member

Ran into this as well on my Win laptop making it almost impossible to complete the verification portion when creating a new wallet. You'll basically have to zoom out to get the entire screen visible.

Example of the default Zoom:

Annotation 2019-12-19 122338

Example of the screen once you zoomed out:

Annotation 2019-12-19 130734

@bbondy bbondy changed the title Wallet screen should be responsive to browser size Wallet backup screen should be responsive to browser size Dec 20, 2019
@srirambv
Copy link
Contributor Author

+1 from @SoaringMoon via #7825

@srirambv
Copy link
Contributor Author

srirambv commented Feb 3, 2020

Verification passed on

Brave 1.5.73 Chromium: 80.0.3987.66 (Official Build) nightly (64-bit)
Revision 56ea77d65c47ecbb1180b99f860d85b51117864a-refs/branch-heads/3987@{#662}
OS Linux
Component 0.1.37
  • Verified wallet backup screen is responsive to browser window height and shows vertical scrollbars

Verification passed on

Brave 1.6.14 Chromium: 80.0.3987.87 (Official Build) nightly (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Windows 10 OS Version 1803 (Build 17134.523)
Component 0.1.42
  • Verified wallet backup screen is responsive to browser window height and shows vertical scrollbars

Verification passed on

Brave 1.6.14 Chromium: 80.0.3987.87 (Official Build) nightly (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS macOS Version 10.15.1 (Build 19B88)
Component 0.1.42
  • Verified wallet backup screen is responsive to browser window height and shows vertical scrollbars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/ethereum-remote-client priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants