Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect to wallet popup needs to be responsive #7882

Closed
dginovker opened this issue Jan 23, 2020 · 3 comments · Fixed by brave/ethereum-remote-client#113
Closed

Connect to wallet popup needs to be responsive #7882

dginovker opened this issue Jan 23, 2020 · 3 comments · Fixed by brave/ethereum-remote-client#113

Comments

@dginovker
Copy link

Description

I was trying to pay for a Forbes article using Crypto and I got a popup asking to set up my Brave wallet. I did and ended up on this screen:

image

If I zoom out on the browser, I can see the connect button. I was confused for a good minute though:

image

Note here is my display configuration:

image

Steps to Reproduce

  1. Set display configuration to 1366x768
  2. Go to a page that asks you to link an account (no idea how, but asking to Pay with Ether in the Forbes link above made me do this)

Actual result:

I couldn't see the "Connect" button

Expected result:

I would be able to easily connect the accounts

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave	1.2.41 Chromium: 79.0.3945.88 (Official Build) unknown (64-bit)
Revision	c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS	Linux
JavaScript	V8 7.9.317.32
User Agent	Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.88 Safari/537.36
Profile Path	/home/dr_cookie/.config/BraveSoftware/Brave-Browser/Default

(Removed the command line note ^)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Unknown
  • Can you reproduce this issue with the dev channel? Unknown
  • Can you reproduce this issue with the nightly channel? Unknown

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? Unrelated
  • Does the issue resolve itself when disabling Brave Rewards? Unrelated
  • Is the issue reproducible on the latest version of Chrome? Unrelated

Miscellaneous Information:

@srirambv
Copy link
Contributor

+1 from @DaniellMesquita via #7862.

@ryanml is this going to be fixed with #7045?

@srirambv srirambv changed the title Crypto Wallets - Connect option with 1366x768 Resolution doesn't show "Connect" Connect to wallet popup needs to be responsive Jan 23, 2020
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 24, 2020
@ryanml ryanml added this to the Ethereum Remote Client 1.0.16 milestone Jan 31, 2020
@srirambv
Copy link
Contributor

srirambv commented Feb 3, 2020

Verification passed on

Brave 1.5.76 Chromium: 80.0.3987.66 (Official Build) nightly (64-bit)
Revision 56ea77d65c47ecbb1180b99f860d85b51117864a-refs/branch-heads/3987@{#662}
OS Linux
Component 0.1.37
  • Verified connect wallet popup in wallet page is responsive and shows vertical scrollbars
    image

Verification passed on

Brave 1.6.14 Chromium: 80.0.3987.87 (Official Build) nightly (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Windows 10 OS Version 1803 (Build 17134.523)
Component 0.1.42
  • Verified connect wallet popup in wallet page is responsive and shows vertical scrollbars when window size is small
    image

Verification passed on

Brave 1.6.14 Chromium: 80.0.3987.87 (Official Build) nightly (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS macOS Version 10.15.1 (Build 19B88)
Component 0.1.42
  • Verified connect wallet popup in wallet page is responsive and shows vertical scrollbars when window size is small

Screen Shot 2020-02-11 at 5 04 09 PM

@danimesq
Copy link

danimesq commented Feb 3, 2020

It isnt very responsive. There is yet a space between the bottom text and footer buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants