Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave Sec Issue #7291

Closed
ryanml opened this issue Dec 9, 2019 · 3 comments · Fixed by brave/brave-core#4186
Closed

Brave Sec Issue #7291

ryanml opened this issue Dec 9, 2019 · 3 comments · Fixed by brave/brave-core#4186
Assignees
@ryanml
Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include security
Milestone
1.2.x - Release

Comments

@ryanml
Copy link
Contributor

ryanml commented Dec 9, 2019

https://github.com/brave/internal/issues/671
@ryanml ryanml added the security label Dec 9, 2019
@ryanml ryanml added this to the 1.4.x - Nightly milestone Dec 9, 2019
@ryanml ryanml self-assigned this Dec 9, 2019
ryanml added a commit to brave/brave-core that referenced this issue Dec 9, 2019
@ryanml
Fixes brave/brave-browser#7291
41f8f91
@ryanml ryanml mentioned this issue Dec 9, 2019
Merged
32 tasks
@ryanml ryanml modified the milestones: 1.4.x - Nightly, 1.2.x - Beta Dec 10, 2019
This was referenced Dec 10, 2019
Merged
Merged
@btlechowski
Copy link

@ryanml Could you add QA/Yes or QA/No label to the issue?

@kjozwiak
Copy link
Member

Definitely a QA/Yes as this is a security issue. The test plan can be found via https://github.com/brave/internal/issues/671#issuecomment-563459417.

@btlechowski
Copy link

btlechowski commented Dec 18, 2019 •
edited by LaurenWags
Loading

Verification passed on

Brave 1.2.29 Chromium: 79.0.3945.79 (Official Build) beta (64-bit)
Revision 29f75ce3f42b007bd80361b0dfcfee3a13ff90b8-refs/branch-heads/3945@{#916}
OS Ubuntu 18.04 LTS

Verified test plan from https://github.com/brave/internal/issues/671#issuecomment-563459417

Verification passed on

Brave 1.2.39 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verified passed with

Brave 1.2.40 Chromium: 79.0.3945.88 (Official Build) (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS macOS Version 10.14.6 (Build 18G103)

This was referenced Dec 24, 2019
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Jan 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include security
Projects
None yet
Milestone
1.2.x - Release
Development

Successfully merging a pull request may close this issue.

Fixing sec issue brave/brave-core
5 participants
@kjozwiak @ryanml @LaurenWags @btlechowski @GeetaSarvadnya