-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Incognito to Private #738
Comments
We're keeping the terminology 'Private Window' and is this a dupe of #772 |
The Incognito window menu item needs to be changed in three places:
Changing the hat-and-classes logo is tracked in #1385 (equivalent change for Tor windows was in #1384). |
Is it just the text strings that need to be updated in this issue? |
Yes but they have to be updated through a script and we need to process extra grd and grdp files which we don't yet. So it's a bit more involved. |
I think we can close that since it has been fixed already. |
This comment has been minimized.
This comment has been minimized.
As it stands, on release version this is only happening on Linux. Windows and mac show @rebron we should re-prioritize this as this has been in backlog for a long time |
+1 from @btlechowski via #6564 |
As per #6564 (comment) this issue doesn't seem to be platform/locale specific. Removing Windows label so that it can be tested on all platforms once fixed |
This was an issue with translations affecting everything except US English. It should now be fixed in the Release channel. |
Description
Rename Incognito to Private tabs
Actual result:
Jump list needs to have a new icon as well
Including incognito icon in a incognito tab
Expected result:
Should be Private tab similar to the recent changes on Android and to match current b-l naming convention
The text was updated successfully, but these errors were encountered: