Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Incognito to Private #738

Closed
srirambv opened this issue Aug 11, 2018 · 21 comments · Fixed by brave/brave-core#683
Closed

Rename Incognito to Private #738

srirambv opened this issue Aug 11, 2018 · 21 comments · Fixed by brave/brave-core#683
Assignees
Labels
design A design change, especially one which needs input from the design team feature/private-browsing feature/user-interface All UI related priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release/not-blocking

Comments

@srirambv
Copy link
Contributor

Description

Rename Incognito to Private tabs

Actual result:

image

Jump list needs to have a new icon as well
image
Including incognito icon in a incognito tab
image

Expected result:

Should be Private tab similar to the recent changes on Android and to match current b-l naming convention

@rebron
Copy link
Collaborator

rebron commented Aug 20, 2018

We're keeping the terminology 'Private Window' and is this a dupe of #772

@srirambv srirambv modified the milestones: Backlog, Releasable builds 0.55.x Aug 21, 2018
@srirambv srirambv assigned petemill and unassigned rossmoody Aug 21, 2018
@bbondy bbondy changed the title Rename Incognito to Private tabs Rename Incognito to Private Aug 21, 2018
@bbondy bbondy modified the milestones: Releasable builds 0.55.x, 1.0 Sep 14, 2018
@rebron rebron added the design A design change, especially one which needs input from the design team label Sep 20, 2018
@tildelowengrimm
Copy link
Contributor

The Incognito window menu item needs to be changed in three places:

  1. the File menu
  2. the three-dots menu in the top right of the browser
  3. the three-dots / alternate click menu on items in the bookmarks manager

Changing the hat-and-classes logo is tracked in #1385 (equivalent change for Tor windows was in #1384).
Launch UI (menu items & shortcuts) for private tabs with Tor is tracked in #1387.

@srirambv
Copy link
Contributor Author

Tool tip needs to be updated as well

image

@riastradh-brave
Copy link
Contributor

Is it just the text strings that need to be updated in this issue?

@riastradh-brave riastradh-brave self-assigned this Oct 11, 2018
@bbondy
Copy link
Member

bbondy commented Oct 12, 2018

Yes but they have to be updated through a script and we need to process extra grd and grdp files which we don't yet. So it's a bit more involved.

@rebron rebron removed this from the 1.0 milestone Oct 16, 2018
@tildelowengrimm tildelowengrimm added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Nov 28, 2018
@tildelowengrimm tildelowengrimm removed the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Nov 28, 2018
@aduh95
Copy link

aduh95 commented Jan 7, 2019

I think we can close that since it has been fixed already.

@2635599

This comment has been minimized.

@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@srirambv
Copy link
Contributor Author

As it stands, on release version this is only happening on Linux. Windows and mac show Private as it should. Linux still shows Incognito.

Screenshot from 2019-07-29 08-53-59
image

@rebron we should re-prioritize this as this has been in backlog for a long time

@srirambv
Copy link
Contributor Author

+1 from @btlechowski via #6564

@srirambv
Copy link
Contributor Author

srirambv commented Oct 21, 2019

As per #6564 (comment) this issue doesn't seem to be platform/locale specific. Removing Windows label so that it can be tested on all platforms once fixed

@petemill petemill added this to the 1.0.0 - Release milestone Dec 2, 2019
@petemill
Copy link
Member

petemill commented Dec 2, 2019

This was an issue with translations affecting everything except US English. It should now be fixed in the Release channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/private-browsing feature/user-interface All UI related priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release/not-blocking
Projects
None yet