Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NTP Sponsored Images data should be versioned #7923

Closed
petemill opened this issue Jan 27, 2020 · 1 comment · Fixed by brave/brave-core#4433
Closed

NTP Sponsored Images data should be versioned #7923

petemill opened this issue Jan 27, 2020 · 1 comment · Fixed by brave/brave-core#4433
Assignees
@petemill
Labels
QA/No release-notes/exclude
Milestone
1.3.x - Release

Comments

@petemill
Copy link
Member

Allows to make breaking changes to sponsored images data without blowing up old builds of the browser.

Old builds should just reject the data and remove the last-known-good data from local memory.
@petemill petemill self-assigned this Jan 27, 2020
@petemill petemill mentioned this issue Jan 27, 2020
Merged
32 tasks
@simonhong simonhong added this to the 1.5.x - Nightly milestone Jan 27, 2020
@bsclifton
Copy link
Member

Marking as QA/No since peer review was done and there is an automated test 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

Labels
QA/No release-notes/exclude
Projects
None yet
Milestone
1.3.x - Release
Development

Successfully merging a pull request may close this issue.

NTP Sponsored Images schemaVersion support brave/brave-core
3 participants
@petemill @bsclifton @simonhong