NTP Sponsored Images schemaVersion support

[petemill]

Only accepts remote component with known schemaVersion of 1

Fix brave/brave-browser#7923

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Android
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that these changes pass automated tests (unit, browser, security tests) on
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that all lint errors/warnings are resolved (npm run lint)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.
• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protection-Mode
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection
  • https://github.com/brave/brave-browser/wiki/QA-Guide

Test Plan:

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[simonhong]

nit: images_data_.reset() also works.

[bsclifton]

Looks like we have a unit test failure (test crashed):
https://ci.brave.com/job/brave-browser-build-pr/job/ntp-sbw-schema-version/1/execution/node/498/log/

01:31:10 [71/842] NTPSponsoredImagesServiceTest.BasicTest (0 ms)
01:31:10 [ RUN ] NTPSponsoredImagesServiceTest.InternalDataTest
01:31:10 [22069:22069:0127/083109.784849:2870384399:ERROR:ntp_sponsored_images_service.cc(135)] Incoming NTP Sponsored images component data was not valid.Schema version was missing, but we expected 1
01:31:10 ../../brave/components/ntp_sponsored_images/browser/ntp_sponsored_images_service_unittest.cc:45: Failure
01:31:10 Expected: (data) != (nullptr), actual: NULL vs (nullptr)
01:31:10 Stack trace:
01:31:10 #0 0x55ec45888c79 (/home/ubuntu/jenkins/workspace/_build-pr_ntp-sbw-schema-version/src/out/Release/brave_unit_tests+0x4ab9c78)
01:31:10
01:31:10 Received signal 11 SEGV_MAPERR 000000000068
01:31:10 #0 0x55ec45888c79 (/home/ubuntu/jenkins/workspace/_build-pr_ntp-sbw-schema-version/src/out/Release/brave_unit_tests+0x4ab9c78)
01:31:10 r8: 0000000000000000 r9: 00007f68d74d4c80 r10: 7365745f74696e75 r11: 0000000000000000
01:31:10 r12: 00003b355deaf918 r13: 00003b355dfb9730 r14: 00007fffa7d24780 r15: 00003b355deaf980
01:31:10 di: 0000000000000000 si: 00003b355dd5acc0 bp: 00007fffa7d246f0 bx: 00003b355e0cc980
01:31:10 dx: 0000000000000002 ax: 0000000000032520 cx: 00003b355dd5acc8 sp: 00007fffa7d246f0
01:31:10 ip: 000055ec458ba3d4 efl: 0000000000010202 cgf: 0000000000000033 erf: 0000000000000004
01:31:10 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000068
01:31:10 [end of stack trace]
01:31:10 Calling _exit(1). Core file will not be generated.
01:31:10 [72/842] NTPSponsoredImagesServiceTest.InternalDataTest (CRASHED)

[simonhong]

Fixed above test failure :)

[bsclifton]

CI ran into network-audit and test-install intermittent issues, but otherwise passed 😄 (built binaries / unit/browser tests all passed)