Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

footer moves to top of NTP if all widgets turned off #7937

Closed
LaurenWags opened this issue Jan 27, 2020 · 4 comments · Fixed by brave/brave-core#4454
Closed

footer moves to top of NTP if all widgets turned off #7937

LaurenWags opened this issue Jan 27, 2020 · 4 comments · Fixed by brave/brave-core#4454

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Jan 27, 2020

Description

Found while testing Scenario 10 from brave/brave-core#4075

If you have your window set to be ~870 px wide or less and you toggle off all widgets, the footer (including SNTP logo if present) moves up to the top of the page.

Steps to Reproduce

  1. Clean or existing profile
  2. Enable the flags necessary to show SNTP
  3. Relaunch
  4. On NTP, toggle off all widgets (clock, stats, rewards, top sites)

Actual result:

Footer moves to the top of the page:
Screen Shot 2020-01-27 at 3 20 21 PM

occurs on normal NTP as well:
Screen Shot 2020-01-27 at 3 22 40 PM

Expected result:

Footer to remain at the bottom of the page (screenshot is from making the page just a bit wider):
Screen Shot 2020-01-27 at 3 21 21 PM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.5.62 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS macOS Version 10.14.6 (Build 18G103)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no, does not reproduce with 1.2.x
  • Can you reproduce this issue with the beta channel? unsure
  • Can you reproduce this issue with the dev channel? no, does not reproduce with 1.4.x
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @brave/legacy_qa @rebron @petemill

@btlechowski
Copy link

Reproduced on Window 7 and Windows 10

Brave 1.5.62 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 7 Service Pack 1 (Build 7601.24544)
Brave 1.5.62 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 10 OS Version 1909 (Build 18363.592)

image

@LaurenWags
Copy link
Member Author

Extra problem with this is, if you are on a non-sponsored NTP and you toggle off all widgets and want to re-toggle them on, you can't do so because when you click on the icon for 'Dashboard Settings', the popup with the toggles can't be seen because it's above the icon, and the icon is already at the top of the window.

when on a sponsored NTP at least you can see part of the popup to be able to toggle 1 item on (which fixes the footer at the top problem momentarily).
Screen Shot 2020-01-27 at 3 29 46 PM

@GeetaSarvadnya
Copy link

Reproduced in Windows 10 x64 - 1.5.63

image

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 31, 2020

Verification passed on

Brave 1.3.106 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the STR from the description
  • Verified on both clean and upgraded profile
    image

Verification passed on

Brave 1.3.108 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Ubuntu 18.04 LTS
  • Verified the STR from the description
  • Verified on both clean and upgraded profile

image

Verification PASSED on macOS 10.15.3 x64 using the following build:

Brave 1.3.108 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS macOS Version 10.15.3 (Build 19D76

Screen Shot 2020-02-04 at 2 13 34 AM

Screen Shot 2020-02-04 at 2 13 08 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment