Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP SI - Previous image is visible after changing from supported region to un-supported region #7946

Closed
simonhong opened this issue Jan 28, 2020 · 1 comment · Fixed by brave/brave-core#4443

Comments

@simonhong
Copy link
Member

simonhong commented Jan 28, 2020

After changing to un supported region from supported region, ntp sponsor image should not be visible.

Repro step

  1. launching brave with clean profile with US region
  2. Turn on the New Tab Page Branded Wallpapers only and re-launch
  3. Check sponsorship image is visible
  4. change OS region to CA and re-launch
  5. Check sponsorship image is not visible
@simonhong simonhong added this to the 1.5.x - Nightly milestone Jan 28, 2020
@simonhong simonhong self-assigned this Jan 28, 2020
simonhong added a commit to brave/brave-core that referenced this issue Jan 28, 2020
If same folder name is used, other component can use it.

Fix brave/brave-browser#7946
@rebron rebron changed the title [SNPT] Previous image is visible after changing from supported region to un-supported region [SNTP] Previous image is visible after changing from supported region to un-supported region Jan 28, 2020
@rebron rebron changed the title [SNTP] Previous image is visible after changing from supported region to un-supported region NTP SI - Previous image is visible after changing from supported region to un-supported region Jan 29, 2020
@btlechowski
Copy link

btlechowski commented Feb 3, 2020

Verification passed on

Brave 1.3.108 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Ubuntu 18.04 LTS

Verified STR from the description. The sponsored images were not shown for Canada.
Used following command lines to trigger region change.
LANG=en_US.UTF-8 LANGUAGE=en_US /usr/bin/brave-browser-beta
LANG=en_CA.UTF-8 LANGUAGE=en_CA /usr/bin/brave-browser-beta

Verification passed on

Brave 1.3.109 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified STR from the description. The sponsored images were not shown for Canada.

Verification PASSED on macOS 10.15.3 x64 using the following build:

Brave 1.3.108 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS macOS Version 10.15.3 (Build 19D76)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment