Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text update needed on Dashboard Settings #7947

Closed
LaurenWags opened this issue Jan 28, 2020 · 6 comments · Fixed by brave/brave-core#5627
Closed

text update needed on Dashboard Settings #7947

LaurenWags opened this issue Jan 28, 2020 · 6 comments · Fixed by brave/brave-core#5627

Comments

@LaurenWags
Copy link
Member

Description

Per the spec for SNTP, Show Background Image should be updated to Show Background Images.

Steps to Reproduce

  1. Clean profile
  2. Enable SNTP from flags, relaunch
  3. Open Dashboard Settings on NTP

Actual result:

Screen Shot 2020-01-27 at 7 32 55 PM

Expected result:

Should say Show Background Images

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.5.62 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS macOS Version 10.14.6 (Build 18G103)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @brave/legacy_qa @rebron @petemill

@gupta437
Copy link

If no one is working actively on this issue, Can I take this issue to work on?

@bsclifton
Copy link
Member

@gupta437 it's all yours! 😄 Let me know if you need help finding where it's stored

@0xedward
Copy link

Hey @gupta437, are you still working on this? If not, I would love to give this a try!

@bsclifton
Copy link
Member

@edwardqiu go for it 😄

@0xedward
Copy link

Hi @bsclifton, this is my first time opening a PR here! Please let me know if there's anything I should change 😄

@bsclifton bsclifton added this to the 1.15.x - Nightly milestone Sep 4, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Sep 17, 2020

Verification PASSED on macOS 10.15.6 x64 using the following build:

Brave | 1.15.55 Chromium: 85.0.4183.102 (Official Build) dev (64-bit)
-- | --
Revision | ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS | macOS Version 10.15.6 (Build 19G73)
  • ensured that Customize --> Background Images under NTP displays Show Background Images when enabled & disabled
  • double checked and ensured that brave://settings/newTab displays the correct strings
Dashboard Settings brave://settings
Screen Shot 2020-09-17 at 11 27 42 AM Screen Shot 2020-09-17 at 11 31 08 AM

Verification passed on

Brave | 1.15.56 Chromium: 85.0.4183.102 (Official Build) dev (64-bit)
-- | --
Revision | ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

  • ensured that Customize --> Background Images under NTP displays Show Background Images when enabled & disabled
  • double checked and ensured that brave://settings/newTab displays the correct strings
Dashboard Settings brave://settings
image image

Verification passed on

Brave 1.15.56 Chromium: 85.0.4183.102 (Official Build) dev (64-bit)
Revision ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS Ubuntu 18.04 LTS
  • ensured that Customize --> Background Images under NTP displays Show Background Images when enabled & disabled
  • double checked and ensured that brave://settings/newTab displays the correct strings
Dashboard Settings brave://settings
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment