Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable background ads on Android #8641

Closed
anthonypkeane opened this issue Mar 11, 2020 · 4 comments · Fixed by brave/brave-core#5348
Closed

Disable background ads on Android #8641

anthonypkeane opened this issue Mar 11, 2020 · 4 comments · Fixed by brave/brave-core#5348
Assignees
@gdregalo
Labels
ARM Android ARM related issues feature/ads OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
Android 1.8.x Rel...

Comments

@anthonypkeane
Copy link

Description

Please disable background ads on Android

and remove the UI from settings

Screenshot_20200311-140635.jpg
@anthonypkeane anthonypkeane added feature/rewards OS/Android Fixes related to Android browser functionality QA/Yes labels Mar 11, 2020
@anthonypkeane anthonypkeane added this to the Android 1.7.x Release milestone Mar 11, 2020
@tmancey tmancey added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 23, 2020
@gdregalo
Copy link

It was decided not to remove background ads now but set them to off for all existing and new installations. And let users to explicitly turn them on if they wish.
https://bravesoftware.slack.com/archives/CB0KCRCQN/p1587149569187400

@gdregalo gdregalo mentioned this issue Apr 23, 2020
Merged
29 tasks
@srirambv
Copy link
Contributor

I don't see any uplift PR's for this issue. The PR fix is marked for 1.10.x. We should move this one out of 1.7.x and may be put it in 1.8.x

cc: @anthonypkeane @gdregalo @SergeyZhukovsky @kjozwiak

@srirambv
Copy link
Contributor

Moving it out of 1.7.x and moving to 1.10.x

This was referenced Apr 24, 2020
Merged
Merged
This was referenced May 6, 2020
Closed
Closed
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 6, 2020 •
edited by btlechowski
Loading

Verification passed on Samsung Galaxy J5 version 5.1.1 running BraveModernarm.apk 1.8.93

  • Verified that the Show Ads when Brave is not in use is disabled by default as per (Disable background ads on Android #8641 (comment))
  • Verified that Ads are not served when the option is disabled and the app is running in the background
  • Verified that Ads are served to the user when Show Ads when Brave is not in use is enabled

Verification passed on BraveModernarm v1.8.93 on Samsung Galaxy Tab S5e (Android 9.0)

  • Verified that the Show Ads when Brave is not in use is disabled by default as per (Disable background ads on Android #8641 (comment))
  • Verified that Ads are not served when the option is disabled and the app is running in the background
  • Verified that Ads are served to the user when Show Ads when Brave is not in use is enabled

@btlechowski btlechowski added ARM Android ARM related issues QA Pass - Android Tab labels May 6, 2020
@kjozwiak kjozwiak mentioned this issue May 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gdregalo gdregalo

Labels
ARM Android ARM related issues feature/ads OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Ads
Archived in project
Milestone
Android 1.8.x Release
Development

Successfully merging a pull request may close this issue.

Android: setting bg brave ads off. Issue #8641. brave/brave-core
8 participants
@tmancey @kjozwiak @anthonypkeane @NejcZdovc @srirambv @btlechowski @gdregalo @GeetaSarvadnya