Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start shared lib only if rewards is enabled #9526

Closed
NejcZdovc opened this issue Apr 29, 2020 · 2 comments · Fixed by brave/brave-core#5924
Closed

Start shared lib only if rewards is enabled #9526

NejcZdovc opened this issue Apr 29, 2020 · 2 comments · Fixed by brave/brave-core#5924

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Apr 29, 2020

We should check preferences (now that we have it) if rewards is enabled or not. If it's not we should not start shared lib.

@LaurenWags
Copy link
Member

LaurenWags commented Jul 31, 2020

Verified passed with

Brave | 1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.14.6 (Build 18G3020)

Clean profile, Rewards not enabled, confirmed BAT Ledger Service is not running:
9526 - clean profile

Enabled Rewards, confirmed BAT Ledger Service is running:
9526 - Rewards enabled

Confirmed able to claim UGP grant:
9526 - confirmed able to claim UGP grant

Disabled Rewards, confirmed BAT Ledger Service is not running:
9526 - Rewards disabled


Verification passed on

Brave | 1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | Windows 10 OS Version 1903 (Build 18362.959)

Clean profile, Rewards not enabled, confirmed BAT Ledger Service is not running:
image

Enabled Rewards, confirmed BAT Ledger Service is running:
image

Confirmed able to claim UGP grant:
image

Disabled Rewards, confirmed BAT Ledger Service is not running:
image


Verification passed on

Brave 1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS Ubuntu 18.04 LTS

Clean profile, Rewards not enabled, confirmed BAT Ledger Service is not running:
image

Enabled Rewards, confirmed BAT Ledger Service is running:
image

Confirmed able to claim UGP grant:
image

Disabled Rewards, confirmed BAT Ledger Service is not running:
image

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.12.109 x64 build

  • Verified toggle rewards on page and enabling it via panel updates the state correctly on panel and page

Verification passed on Samsung Tab A with Android 10 running 1.12.109 x64 build

  • Verified toggle rewards on page and enabling it via panel updates the state correctly on panel and page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment