Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Brave Ads 30-day history segment does not fit #9799

Closed
jonathansampson opened this issue May 16, 2020 · 1 comment
Closed

Fix Brave Ads 30-day history segment does not fit #9799

jonathansampson opened this issue May 16, 2020 · 1 comment
Assignees
@tmancey
Labels
bug closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. design A design change, especially one which needs input from the design team feature/ads needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution.

Comments

@jonathansampson
Copy link
Contributor

Description

The 7-Day Ads History popup appears to have overflow issues, possibly caused in part by lengthy, non-wrapping category names.

Steps to Reproduce

Open 7-Day Ads History on Windows

Actual result:

It is likely you will see a horizontal scrollbar.

Expected result:

Only a vertical scrollbar should be necessary.

Reproduces how often:

Always.

Brave version (brave://version info)

1.8.96

Miscellaneous Information:

image
@jonathansampson jonathansampson added bug design A design change, especially one which needs input from the design team labels May 16, 2020
@tmancey tmancey added design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. and removed design A design change, especially one which needs input from the design team labels Oct 9, 2020
@tmancey tmancey added the blocked label Oct 9, 2020
@tmancey tmancey changed the title Ads History Has Overflow Issues 7-day Brave ads history segment does not fit Mar 12, 2021
This was referenced Aug 18, 2021
Closed
Closed
@tmancey tmancey added design A design change, especially one which needs input from the design team needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. and removed design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels Feb 15, 2022
@tmancey tmancey changed the title 7-day Brave ads history segment does not fit Fix Brave Ads 30-day history segment does not fit Apr 13, 2023
@tmancey tmancey added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label May 30, 2023
@tmancey tmancey self-assigned this May 30, 2023
@tmancey
Copy link
Contributor

tmancey commented May 30, 2023

Closing as resolved by another issue

@tmancey tmancey closed this as completed May 30, 2023
@tmancey tmancey removed the blocked label Jun 14, 2023
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. design A design change, especially one which needs input from the design team feature/ads needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution.
Projects
Ads
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonathansampson @tmancey @bsclifton