Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave News Display Ads length may affect Brave Ads History render #17575

Closed
iambrianfung opened this issue Aug 19, 2021 · 2 comments · Fixed by brave/brave-core#9793
Closed

Comments

@iambrianfung
Copy link
Collaborator

iambrianfung commented Aug 19, 2021

Description

The new Brave News Display ads have a different character length limit than Push Notification Ads. The title property of the creative gets shown in the Ads History and mess with the way we render the creatives.

Likely the cause of: #17543
Similar to issue: #9799

Steps to Reproduce

  1. Open Brave News
  2. Attempt to find a Brave Stickers Ad in Brave News
  3. Look at Ads History

Actual result:

Screen Shot 2021-08-19 at 13 54 11

Screen Shot 2021-08-19 at 14 14 25

Expected result:

Probably do some kind of text wrap

Brave version (brave://version info)

1.28.105 Chromium: 92.0.4515.131 (Official Build) (arm64)

Version/Channel Information:

Release, but likely all channels

@tmancey tmancey added bug design A design change, especially one which needs input from the design team QA/Yes release-notes/exclude priority/P3 The next thing for us to work on. It'll ride the trains. labels Aug 19, 2021
@tmancey tmancey self-assigned this Aug 19, 2021
@tmancey tmancey removed the design A design change, especially one which needs input from the design team label Aug 19, 2021
@tmancey tmancey added this to the 1.30.x - Nightly milestone Aug 20, 2021
@stephendonner
Copy link

stephendonner commented Aug 24, 2021

Verified PASSED using

Brave 1.30.45 Chromium: 93.0.4577.51 (Official Build) nightly (64-bit)
Revision 762d21050e2da59930c784c09b134d0b0b148188-refs/branch-heads/4577@{#915}
OS Windows 10 OS Version 2009 (Build 22000.160)

Steps:

  1. clean profile
  2. launch Brave
  3. open brave://rewards and click Start using Rewards
  4. open a new-tab page
  5. scroll down
  6. click on Show Brave News
  7. keep scrolling until you see one or more ads with long titles
  8. load brave://rewards again

Confirmed the ads' titles are cropped, with an ellipsis ... for the missing text.

ads-history-panel


Verified PASSED using

Brave 1.30.57 Chromium: 93.0.4577.58 (Official Build) beta (x86_64)
Revision c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS macOS Version 12.0 (Build 21A5506j)

Steps:

  1. clean profile
  2. launch Brave
  3. open brave://rewards and click Start using Rewards
  4. open a new-tab page
  5. scroll down
  6. click on Show Brave News
  7. keep scrolling until you see one or more ads with long titles
  8. load brave://rewards again

Confirmed the ads' titles are cropped, with an ellipsis ... for the missing text.

Screen Shot 2021-09-02 at 5 39 11 PM


Verification passed on

Brave 1.30.65 Chromium: 93.0.4577.63 (Official Build) beta (64-bit)
Revision ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS Ubuntu 18.04 LTS

Verified test plan from the description

image

@btlechowski
Copy link

Good to check on all platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment