Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Chrome logo appears when flipping open tabs #9867

Closed
georapbox opened this issue May 21, 2020 · 5 comments · Fixed by brave/brave-core#8170
Closed

[Android] Chrome logo appears when flipping open tabs #9867

georapbox opened this issue May 21, 2020 · 5 comments · Fixed by brave/brave-core#8170
Assignees
Labels
android-phone-specific branding good first issue OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include

Comments

@georapbox
Copy link

Description

When having a couple of open tabs and you swipe vertically repeatedly the open tabs flip and the Google Chrome logo is displayed. This started to happen after Android version was rebased on brave-core. Previous to this update it used to display the Brave logo.

Steps to reproduce

  1. Have at least 2 tabs open.
  2. Tap on the tabs button on the bottom right of the screen (the one that displays the number of open tabs)
  3. Swipe vertically from bottom to top with your finger repeatedly for 5 or 6 times.

Actual result

Tabs flip vertically and Chrome logo is shown while flipping.
May-21-2020 10-49-02

Expected result

While tabs flip the Brave logo should be displayed instead of Chrome's as used to be the case before the rebase with the brave-core.

Issue reproduces how often

Always

Issue happens on

  • Current Play Store version

Device details

  • Install type (ARM, x86): ARM
  • Device (Phone, Tablet, Phablet): Phone Motorola One (XT1941-4)
  • Android version: 10

Brave version

Brave 1.8.112

@georapbox georapbox added the OS/Android Fixes related to Android browser functionality label May 21, 2020
@lOscarl
Copy link

lOscarl commented Jun 8, 2020

Hello, I'm new in the Open Source world, can I take this issue?

@srirambv
Copy link
Contributor

srirambv commented Jun 8, 2020

@lOscarl that would be great. You can please follow the guidelines mentioned here

Self assigning so you can work on this one

@srirambv srirambv self-assigned this Jun 8, 2020
@kjozwiak
Copy link
Member

Getting several +1 from the community via the following thread:

CCing @SergeyZhukovsky @aekeus

@srirambv
Copy link
Contributor

+1 from @pragyanone via #11507

@anthonypkeane anthonypkeane added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 2, 2020
@srirambv srirambv removed their assignment Feb 23, 2021
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Mar 7, 2021
@AlexeyBarabash AlexeyBarabash self-assigned this Mar 7, 2021
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Mar 19, 2021
@AlexeyBarabash AlexeyBarabash added this to the 1.24.x - Nightly milestone Mar 19, 2021
@stephendonner
Copy link

Verified PASSED using Brave 1.24.76, Chromium 90.0.4430.85 on Android 9, Pixel XL, arm64.

Steps:

  1. opened a few tabs
  2. opened Settings > Appearance > deselected Enable Tab Groups
  3. tapped on the tab switcher icon
  4. swiped up a few times on one of the displayed tabs, until the tab card rotated

Confirmed there was no Google Chrome logo on the card

mobizen_20210429_165850.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android-phone-specific branding good first issue OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants