Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable software update by default when yarn start #576

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Disable software update by default when yarn start #576

merged 1 commit into from
Jul 18, 2018

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jul 18, 2018 •
edited
Loading

On MacOSX, update is triggered in official build.
On Windows, however, it isn't.

Close #575

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

Check --disable-brave-update is attached when yarn start without --enable_brave_update

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions

@simonhong
Disable software update when yarn start Release
45db0d3 
On MacOSX, update is triggered in official build.
On Windows, however, it isn't.
@simonhong simonhong self-assigned this Jul 18, 2018
@simonhong simonhong requested a review from RyanJarv July 18, 2018 01:11
@simonhong simonhong changed the title Disable software update when yarn start Release Disable software update by default when yarn start Jul 18, 2018
RyanJarv
RyanJarv approved these changes Jul 18, 2018
View reviewed changes
Copy link
Contributor

@RyanJarv RyanJarv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simonhong simonhong merged commit 96c2914 into master Jul 18, 2018
@simonhong simonhong deleted the disable_update_by_default branch July 18, 2018 03:46
@simonhong simonhong mentioned this pull request Jul 19, 2018
Closed
@Kingcrypto38 Kingcrypto38 mentioned this pull request Jan 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanJarv RyanJarv RyanJarv approved these changes

Assignees

@simonhong simonhong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonhong @RyanJarv