Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use safe_browsing_mode=2 for Android #8664

Merged
merged 1 commit into from
Mar 13, 2020
Merged

Use safe_browsing_mode=2 for Android #8664

merged 1 commit into from
Mar 13, 2020

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Mar 12, 2020

Fix #8381

This enables it locally and builds fine, but doesn't work locally. I think because it needs to be a play store build and not just a local build. I think we should try landing this and see if it works. If it doesn't then we can dig in more.

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bbondy bbondy added this to the 1.8.x - Nightly milestone Mar 12, 2020
@bbondy bbondy self-assigned this Mar 12, 2020
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Safe Browsing doesn't work in android-core
2 participants