Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix safe browsing label (uplift to 1.8) #9479

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Apr 27, 2020

Uplift of #9411

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@simonhong simonhong added this to the 1.8.x - Release milestone Apr 27, 2020
@simonhong simonhong requested a review from a team April 27, 2020 01:31
@simonhong simonhong self-assigned this Apr 27, 2020
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.8.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per brave/brave-core#5335 (comment).

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 9cbc3a3 into 1.8.x Apr 30, 2020
@kjozwiak kjozwiak deleted the fix_safe_browing_label_1_8 branch April 30, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants