Skip to content

Commit

Permalink
Added patch to support JSON_ALLOW_TRAILING_COMMAS
Browse files Browse the repository at this point in the history
  • Loading branch information
spylogsster committed Mar 24, 2022
1 parent 4555187 commit 0e8834b
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
12 changes: 12 additions & 0 deletions chromium_src/services/data_decoder/public/cpp/data_decoder.cc
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
/* Copyright (c) 2022 The Brave Authors. All rights reserved.
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
* You can obtain one at http://mozilla.org/MPL/2.0/. */

#include "base/json/json_reader.h"

#include "src/services/data_decoder/public/cpp/data_decoder.h"

#define JSON_PARSE_RFC JSON_PARSE_RFC | base::JSON_ALLOW_TRAILING_COMMAS
#include "src/services/data_decoder/public/cpp/data_decoder.cc"
#undef JSON_PARSE_RFC
5 changes: 4 additions & 1 deletion components/api_request_helper/api_request_helper_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,10 @@ TEST_F(ApiRequestHelperUnitTest, SanitizedRequest) {
SendRequest("{", "");
SendRequest("0", "");
SendRequest("a", "");
SendRequest("{\"a\":1,}", "");
// Android's sanitizer doesn't support trailing commas.
#if !BUILDFLAG(IS_ANDROID)
SendRequest("{\"a\":1,}", "{\"a\":1}");
#endif
}

TEST_F(ApiRequestHelperUnitTest, RequestWithConversion) {
Expand Down

0 comments on commit 0e8834b

Please sign in to comment.