Skip to content

Commit

Permalink
Add login.live.com exception for HTTP Accept-Language farbling (uplif…
Browse files Browse the repository at this point in the history
…t to 1.53.x) (#19023)

Uplift of #18987 (squashed) to release
  • Loading branch information
brave-builds committed Jun 26, 2023
1 parent 418f6b3 commit 8948d04
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,7 @@ IN_PROC_BROWSER_TEST_F(BraveNavigatorLanguagesFarblingBrowserTest,
std::string domain_d = "d.test";
std::string domain_x = "www.ulta.com";
std::string domain_y = "aeroplan.rewardops.com";
std::string domain_z = "login.live.com";
GURL url_b = https_server_.GetURL(
domain_b, "/reduce-language/page-with-subresources.html");
GURL url_d = https_server_.GetURL(
Expand All @@ -266,6 +267,8 @@ IN_PROC_BROWSER_TEST_F(BraveNavigatorLanguagesFarblingBrowserTest,
domain_x, "/reduce-language/page-with-subresources.html");
GURL url_y = https_server_.GetURL(
domain_y, "/reduce-language/page-with-subresources.html");
GURL url_z = https_server_.GetURL(
domain_z, "/reduce-language/page-with-subresources.html");
SetAcceptLanguages("la,es,en");

// Farbling level: off
Expand Down Expand Up @@ -328,4 +331,6 @@ IN_PROC_BROWSER_TEST_F(BraveNavigatorLanguagesFarblingBrowserTest,
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), url_x));
BlockFingerprinting(domain_y);
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), url_y));
BlockFingerprinting(domain_z);
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), url_z));
}
4 changes: 3 additions & 1 deletion browser/net/brave_reduce_language_network_delegate_helper.cc
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ static constexpr auto kFarbleAcceptLanguageExceptions =
{// https://github.com/brave/brave-browser/issues/25309
"ulta.com", "www.ulta.com",
// https://github.com/brave/brave-browser/issues/26325
"aeroplan.rewardops.com"});
"aeroplan.rewardops.com",
// https://github.com/brave/brave-browser/issues/31196
"login.live.com"});
} // namespace

std::string FarbleAcceptLanguageHeader(
Expand Down

0 comments on commit 8948d04

Please sign in to comment.