Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom header sent to Uphold #10052

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Remove custom header sent to Uphold #10052

merged 1 commit into from
Sep 13, 2021

Conversation

ShivanKaul
Copy link
Collaborator

@ShivanKaul ShivanKaul commented Sep 10, 2021 •
edited by fmarier
Loading

Resolves brave/brave-browser#18015

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Described in brave/brave-browser#18015

simonhong
simonhong reviewed Sep 13, 2021
View reviewed changes
browser/net/brave_referrals_network_delegate_helper_unittest.cc Outdated
@@ -21,7 +21,6 @@ using brave::ResponseCallback;

TEST(BraveReferralsNetworkDelegateHelperTest, ReplaceHeadersForMatchingDomain) {
const std::array<std::tuple<GURL, std::string>, 2> test_cases = {
Copy link
Member

@simonhong simonhong Sep 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

array size to 1? and maybe we don't need to use array anymore cause it has only one item.

simonhong
simonhong approved these changes Sep 13, 2021
View reviewed changes
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@ShivanKaul ShivanKaul merged commit 6bda5a7 into master Sep 13, 2021
@ShivanKaul ShivanKaul deleted the remove-uphold-custom-header branch September 13, 2021 20:06
@ShivanKaul ShivanKaul added this to the 1.31.x - Beta milestone Sep 17, 2021
@fmarier
Copy link
Member

fmarier commented Oct 4, 2021

https://github.com/brave/brave-browser/wiki/Custom-Headers now updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonhong simonhong simonhong approved these changes

@iefremov iefremov iefremov approved these changes

Assignees

@ShivanKaul ShivanKaul

Labels
None yet
Projects
None yet
Milestone
1.31.x - Release
Development

Successfully merging this pull request may close these issues.

Remove Uphold custom header
4 participants
@ShivanKaul @fmarier @iefremov @simonhong