Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes custom ad notifications are not shown when system notification are disabled - 1.31.x #10272

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Fixes custom ad notifications are not shown when system notification are disabled - 1.31.x #10272

merged 1 commit into from
Oct 8, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Sep 27, 2021 •
edited by kjozwiak
Loading

Uplift of #10252
Resolves brave/brave-browser#18351

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey requested a review from a team September 27, 2021 16:27
@tmancey tmancey self-assigned this Sep 27, 2021
@tmancey tmancey added this to the 1.31.x - Beta milestone Sep 27, 2021
kjozwiak
kjozwiak approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.31.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #10252 (comment).

@kjozwiak kjozwiak merged commit eba21c5 into 1.31.x Oct 8, 2021
@kjozwiak kjozwiak deleted the issues/18351-1.31.x branch October 8, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@tmancey tmancey

Labels
feature/ads
Projects
None yet
Milestone
1.31.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@tmancey @kjozwiak