Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use provider-neutral text on Rewards reset modal #10520

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Oct 14, 2021

Resolves brave/brave-browser#18105

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See linked issue.

Screen Shot 2021-10-14 at 12 34 01 PM

@zenparsing zenparsing requested a review from a team as a code owner October 14, 2021 16:17
@zenparsing zenparsing self-assigned this Oct 14, 2021
@zenparsing zenparsing force-pushed the ksmith-reset-wallet-text branch from 4c12559 to a5e51da Compare October 14, 2021 16:34
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zenparsing zenparsing merged commit 260e552 into master Oct 15, 2021
@zenparsing zenparsing deleted the ksmith-reset-wallet-text branch October 15, 2021 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make text on Reset page of Manage Your Wallet more custodian neutral
3 participants