Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-organize calls sequence at P3aOnboardingActivity class (uplift to 1.31.x) #10593

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Re-organize calls sequence at P3aOnboardingActivity class (uplift to 1.31.x) #10593

merged 1 commit into from
Oct 21, 2021

Conversation

AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented Oct 19, 2021 •
edited by kjozwiak
Loading

Uplift of #10576
Resolves brave/brave-browser#18825
Resolves brave/brave-browser#18776

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@AlexeyBarabash AlexeyBarabash requested a review from a team October 19, 2021 12:58
@AlexeyBarabash AlexeyBarabash self-assigned this Oct 19, 2021
@AlexeyBarabash AlexeyBarabash added this to the 1.31.x - Release #2 milestone Oct 19, 2021
kjozwiak
kjozwiak approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.31.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #10576 (comment).

@kjozwiak kjozwiak merged commit e5378e2 into 1.31.x Oct 21, 2021
@kjozwiak kjozwiak deleted the pr10576_android_p3a_crash_1.31.x branch October 21, 2021 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@AlexeyBarabash AlexeyBarabash

Labels
None yet
Projects
None yet
Milestone
1.31.x - Release #2
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexeyBarabash @kjozwiak