Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GetAllSyncData workaround for local overridden issue #1079

Merged
merged 1 commit into from
Dec 13, 2018

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Dec 13, 2018

which is needed to be addressed in sync library
brave/sync#261

fix brave/brave-browser#2447
fix brave/brave-browser#2512

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@darkdh darkdh merged commit 18e312f into master Dec 13, 2018
darkdh added a commit that referenced this pull request Dec 13, 2018
Remove GetAllSyncData workaround for local overridden issue
@darkdh
Copy link
Member Author

darkdh commented Dec 13, 2018

master: 18e312f
0.60x: 654524e

@kjozwiak
Copy link
Member

@darkdh uplift request to 0.58.x approved after deliberating with @rebron & @srirambv. Please ensure that the correct labels are removed/added and that the associated issue is moved to the correct milestone.

darkdh added a commit that referenced this pull request Dec 13, 2018
Remove GetAllSyncData workaround for local overridden issue
darkdh added a commit that referenced this pull request Dec 13, 2018
Remove GetAllSyncData workaround for local overridden issue
@darkdh
Copy link
Member Author

darkdh commented Dec 13, 2018

0.59.x: 2db9181
0.58.x: 2d039b0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync: move bookmark into folder not reflected sync does not put Android bookmarks into folders
4 participants