Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset sync chain and clear prefs right away when transaport state is not active #10841

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Nov 3, 2021

Resolves brave/brave-browser#19199

It's very often that transport layer is in initializing state, and there is no point wait for device info deletion

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

In the issue

@darkdh darkdh requested a review from a team as a code owner November 3, 2021 01:06
@darkdh darkdh self-assigned this Nov 3, 2021
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kjozwiak
Copy link
Member

kjozwiak commented Nov 4, 2021

Verification PASSED on Win 11 x64 using the following build:

Brave | 1.33.58 Chromium: 95.0.4638.69 (Official Build) nightly (64-bit)
-- | --
Revision | 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS | Windows 11 Version 21H2 (Build 22000.282)

Verified using the STR/Cases outlined via brave/brave-browser#19199. Basically made sure that you can leave a sync chain while the network is disabled.

Initial Sync Chain Disabled Network Leaving Sync Chain Left Sync Chain Left Sync Chain
syncChain1 networkDisabled leavingSyncChain leftSync1 leftSync2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot leave sync chain when offline/error
3 participants