Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passed Active Origin to Allow Spend Panel #11132

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

Douglashdaniel
Copy link
Contributor

Description

The AllowSpend Panel had a hardcoded value of 'https://app.compound.finance' for siteUrl
It is now being passed the sites activeOrigin

Resolves brave/brave-browser#19534

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Before:

Screen Shot 2021-11-17 at 9 43 14 AM

After:

Screen Shot 2021-11-17 at 9 33 48 AM

@Douglashdaniel Douglashdaniel self-assigned this Nov 17, 2021
@Douglashdaniel Douglashdaniel force-pushed the allow-spend-active-origin branch from 83b4707 to 4af50dc Compare November 17, 2021 16:56
Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.34.22 Chromium: 96.0.4664.45 (Official Build) nightly (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Linux
  • Verified hardcoded text is removed and shows the current protocol origin
    image
  • Encountered #19556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Hardcoded URL in AllowSpend Panel
3 participants