Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds grant claim process to Rewards (0.60) #1138

Merged
merged 1 commit into from
Dec 19, 2018
Merged

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Dec 19, 2018

Related: brave/brave-browser#1783
(0.61): #1092

4 related UI commits were cherry picked in to the 0.60 feature branch as seen here:

https://github.com/brave/brave-ui/commits/brave-core-0.60.x

The hash this PR should be pointing at is the HEAD from above, which is: 290b128ac3f607bfc9cf084417c859df1a1d3779

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

Adds grant claim process to Rewards Panel
@ryanml ryanml merged commit 350b2a6 into 0.60.x Dec 19, 2018
@ryanml ryanml deleted the feature-1783-0.60 branch December 19, 2018 17:09
NejcZdovc pushed a commit that referenced this pull request Jan 14, 2019
Adds grant claim process to Rewards (0.60)
@bbondy bbondy added this to the 0.60.x - Dev milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants